From: Peter Zijlstra <peterz@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Oleg Nesterov <oleg@redhat.com>,
David Howells <dhowells@redhat.com>,
Steven Whitehouse <swhiteho@redhat.com>,
dm-devel@redhat.com, Chris Mason <clm@fb.com>,
Josef Bacik <jbacik@fb.com>, Steve French <sfrench@samba.org>,
Theodore Ts'o <tytso@mit.edu>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Ingo Molnar <mingo@redhat.com>,
Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions.
Date: Thu, 1 May 2014 11:31:40 +0200 [thread overview]
Message-ID: <20140501093140.GN11096@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140501192605.6b5383f8@notabene.brown>
On Thu, May 01, 2014 at 07:26:05PM +1000, NeilBrown wrote:
> On Thu, 1 May 2014 09:42:57 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Thu, May 01, 2014 at 12:37:38PM +1000, NeilBrown wrote:
> > > +static inline int
> > > +wait_on_bit(void *word, int bit, unsigned mode)
> > > +{
> > > + if (!test_bit(bit, word))
> > > + return 0;
> > > + return out_of_line_wait_on_bit(word, bit,
> > > + bit_wait,
> > > + mode & 65535);
> > > +}
> >
> > Still puzzled by the 16 bit mask there ;-)
>
> I clearly remember removing that!
> And I've just done it again.
> I hope it doesn't re-reappear!
> :-)
> NeilBrown
Seems dead now, I'll hold out for a little while so that dhowells can
explain this fscache thing.
Then I'll queue it. Ingo is currently enjoying a long weekend and is
fighting (well I am now) a stability issue in -tip kernels, so it might
be a little while before it actually shows up in the git tree.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Oleg Nesterov <oleg@redhat.com>,
David Howells <dhowells@redhat.com>,
Steven Whitehouse <swhiteho@redhat.com>,
dm-devel@redhat.com, Chris Mason <clm@fb.com>,
Josef Bacik <jbacik@fb.com>, Steve French <sfrench@samba.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Ingo Molnar <mingo@redhat.com>,
Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions.
Date: Thu, 1 May 2014 11:31:40 +0200 [thread overview]
Message-ID: <20140501093140.GN11096@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140501192605.6b5383f8@notabene.brown>
On Thu, May 01, 2014 at 07:26:05PM +1000, NeilBrown wrote:
> On Thu, 1 May 2014 09:42:57 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Thu, May 01, 2014 at 12:37:38PM +1000, NeilBrown wrote:
> > > +static inline int
> > > +wait_on_bit(void *word, int bit, unsigned mode)
> > > +{
> > > + if (!test_bit(bit, word))
> > > + return 0;
> > > + return out_of_line_wait_on_bit(word, bit,
> > > + bit_wait,
> > > + mode & 65535);
> > > +}
> >
> > Still puzzled by the 16 bit mask there ;-)
>
> I clearly remember removing that!
> And I've just done it again.
> I hope it doesn't re-reappear!
> :-)
> NeilBrown
Seems dead now, I'll hold out for a little while so that dhowells can
explain this fscache thing.
Then I'll queue it. Ingo is currently enjoying a long weekend and is
fighting (well I am now) a stability issue in -tip kernels, so it might
be a little while before it actually shows up in the git tree.
next prev parent reply other threads:[~2014-05-01 9:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 2:37 [PATCH] SCHED: remove proliferation of wait_on_bit action functions NeilBrown
2014-05-01 7:42 ` Peter Zijlstra
2014-05-01 7:42 ` Peter Zijlstra
2014-05-01 9:26 ` NeilBrown
2014-05-01 9:31 ` Peter Zijlstra [this message]
2014-05-01 9:31 ` Peter Zijlstra
2014-05-13 16:06 ` David Howells
2014-05-13 16:06 ` David Howells
2014-05-13 16:45 ` Peter Zijlstra
2014-05-13 16:45 ` Peter Zijlstra
2014-05-13 16:08 ` David Howells
2014-05-13 16:08 ` David Howells
2014-05-19 13:08 ` [tip:sched/core] sched: Remove " tip-bot for NeilBrown
2014-05-22 9:05 ` [PATCH] SCHED: remove " Ingo Molnar
2014-05-22 9:05 ` Ingo Molnar
2014-05-22 9:50 ` NeilBrown
2014-06-05 12:45 ` Ingo Molnar
2014-06-05 12:45 ` Ingo Molnar
2014-06-05 12:45 ` Ingo Molnar
2014-06-06 0:23 ` NeilBrown
2014-06-06 6:04 ` Ingo Molnar
2014-06-06 6:04 ` Ingo Molnar
2014-07-02 1:28 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501093140.GN11096@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=dhowells@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=sfrench@samba.org \
--cc=swhiteho@redhat.com \
--cc=trond.myklebust@primarydata.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.