From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] Use signed location for drmModeSetPlane Date: Thu, 1 May 2014 23:41:33 +0300 Message-ID: <20140501204133.GQ18465@intel.com> References: <1398945403-19018-1-git-send-email-djkurtz@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id C050F6E0FF for ; Thu, 1 May 2014 13:41:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1398945403-19018-1-git-send-email-djkurtz@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Kurtz Cc: dri-devel@lists.freedesktop.org, Jesse Barnes List-Id: dri-devel@lists.freedesktop.org On Thu, May 01, 2014 at 07:56:43PM +0800, Daniel Kurtz wrote: > DRM_IOCTL_MODE_SETPLANE crtc_x, crtc_y are s32. > This is to allow a destination location that is partially off screen. > = > Make this more obvious to users of libdrm by using signed crtc_x/_y > parameters for drmModeSetPlane() as well. > = > Signed-off-by: Daniel Kurtz Reviewed-by: Ville Syrj=E4l=E4 and pushed. > --- > xf86drmMode.c | 2 +- > xf86drmMode.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/xf86drmMode.c b/xf86drmMode.c > index a6bb2ee..7ca89b3 100644 > --- a/xf86drmMode.c > +++ b/xf86drmMode.c > @@ -906,7 +906,7 @@ int drmModePageFlip(int fd, uint32_t crtc_id, uint32_= t fb_id, > = > int drmModeSetPlane(int fd, uint32_t plane_id, uint32_t crtc_id, > uint32_t fb_id, uint32_t flags, > - uint32_t crtc_x, uint32_t crtc_y, > + int32_t crtc_x, int32_t crtc_y, > uint32_t crtc_w, uint32_t crtc_h, > uint32_t src_x, uint32_t src_y, > uint32_t src_w, uint32_t src_h) > diff --git a/xf86drmMode.h b/xf86drmMode.h > index 9bcb1d1..6eab565 100644 > --- a/xf86drmMode.h > +++ b/xf86drmMode.h > @@ -445,7 +445,7 @@ extern drmModePlaneResPtr drmModeGetPlaneResources(in= t fd); > extern drmModePlanePtr drmModeGetPlane(int fd, uint32_t plane_id); > extern int drmModeSetPlane(int fd, uint32_t plane_id, uint32_t crtc_id, > uint32_t fb_id, uint32_t flags, > - uint32_t crtc_x, uint32_t crtc_y, > + int32_t crtc_x, int32_t crtc_y, > uint32_t crtc_w, uint32_t crtc_h, > uint32_t src_x, uint32_t src_y, > uint32_t src_w, uint32_t src_h); > -- = > 1.9.1.423.g4596e3a > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel OTC