From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/2] net/designware: reorder struct dw_eth_dev to pack more efficiently.
Date: Thu, 1 May 2014 21:23:29 +0200 [thread overview]
Message-ID: <201405012123.29978.marex@denx.de> (raw)
In-Reply-To: <1398970918.19277.181.camel@hastur.hellion.org.uk>
On Thursday, May 01, 2014 at 09:01:58 PM, Ian Campbell wrote:
> The {tx,rx}_mac_descrtable fields are aligned to ARCH_DMA_MINALIGN, which
> could be 256 or even larger. That means there is a potentially huge hole
> in the struct before those fields, so move them to the front where they
> are better packed.
>
> Moving them to the front also helps ensure that so long as dw_eth_dev is
> properly aligned (which it is since "net/designware: ensure device private
> data is DMA aligned.") the {tx,rx}_mac_descrtable will be too, or at least
> avoids having to worry too much about compiler specifics.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-05-01 19:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 19:50 [U-Boot] [PATCH v2 2/2] net/designware: ensure cache invalidations are aligned to ARCH_DMA_MINALIGN Ian Campbell
2014-05-01 19:01 ` [U-Boot] [PATCH 3/2] net/designware: reorder struct dw_eth_dev to pack more efficiently Ian Campbell
2014-05-01 19:23 ` Marek Vasut [this message]
2014-05-14 7:44 ` [U-Boot] [linux-sunxi] " Siarhei Siamashka
2014-05-14 7:52 ` Ian Campbell
2014-05-14 8:01 ` Siarhei Siamashka
2014-05-14 8:32 ` Siarhei Siamashka
2014-05-14 9:25 ` Ian Campbell
2014-05-14 9:49 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201405012123.29978.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.