From: Jonathan Nieder <jrnieder@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Duy Nguyen <pclouds@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Define constants for lengths of object names
Date: Thu, 1 May 2014 16:05:53 -0700 [thread overview]
Message-ID: <20140501230553.GE9218@google.com> (raw)
In-Reply-To: <20140501230041.GC75770@vauxhall.crustytoothpaste.net>
brian m. carlson wrote:
> On Thu, May 01, 2014 at 10:20:07AM -0700, Jonathan Nieder wrote:
>> What happened to the
>>
>> struct object_id {
>> unsigned char id[20];
>> };
>>
>> ...
>>
>> struct object {
>> ...
>> struct object_id id;
>> };
>>
>> idea?
>
> There didn't seem to be a huge amount of support for it.
I can make up for it in enthuasiasm. Please? It's something I've
wanted for a long time but never found the time to do.
> Also, there
> were concerns that some architectures might impose alignment constraints
> on it that made sizeof(struct object_id) != 20.
Sounds awful. What architecture?
Thanks,
Jonathan
next prev parent reply other threads:[~2014-05-01 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 11:06 [PATCH] Define constants for lengths of object names brian m. carlson
2014-05-01 17:20 ` Jonathan Nieder
2014-05-01 18:23 ` Jonathan Nieder
2014-05-01 23:00 ` brian m. carlson
2014-05-01 23:05 ` Jonathan Nieder [this message]
2014-05-02 0:15 ` Duy Nguyen
2014-05-02 22:09 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501230553.GE9218@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.