From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 01/12] Config.mk: move directory list into BUILD_MAKE_VARS Date: Fri, 2 May 2014 12:57:04 +0200 Message-ID: <20140502105704.GA5612@aepfle.de> References: <1398328615-28461-1-git-send-email-olaf@aepfle.de> <1398328615-28461-2-git-send-email-olaf@aepfle.de> <1399027235.32736.23.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1399027235.32736.23.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, May 02, Ian Campbell wrote: > Probably doesn't matter for this particular patch, but I fear it might > for the upcoming changes you refer to. Did you test a stubdom build with > them? Yes. > > $(foreach var, \ > > - SBINDIR BINDIR LIBEXEC LIBDIR SHAREDIR PRIVATE_BINDIR \ > > - XENFIRMWAREDIR XEN_CONFIG_DIR XEN_SCRIPT_DIR XEN_LOCK_DIR \ > > - XEN_RUN_DIR XEN_PAGING_DIR, \ > > + $(BUILD_MAKE_VARS), \ > > I think this can now go on the same line as the foreach. Possibly the > whole thing might fit on one line now too? It was too long, but I have to double check. Olaf