From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 07/12 v4] tools/pygrub: store kernels in
 /var/run/xen/pygrub
Date: Fri, 2 May 2014 13:02:47 +0200
Message-ID: <20140502110247.GC5612@aepfle.de>
References: <1398328615-28461-8-git-send-email-olaf@aepfle.de>
	<1398341529-10585-1-git-send-email-olaf@aepfle.de>
	<1399027798.32736.31.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1399027798.32736.31.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, May 02, Ian Campbell wrote:

> On Thu, 2014-04-24 at 14:12 +0200, Olaf Hering wrote:
> > Move location of temporary bootfiles from /var/run/xend/boot to
> > /var/run/xen/pygrub. Create the subdirectory if does not exist, unless
> > --output-directory=<dir> was specified.
> 
> I'm not at all opposed to this change but why this last condition? Any
> reason not to always create the directory if it doesn't exist?
> 
> Or should there be an existence check when you specify
> --output-directory?

Without --output-directory the default should be created internally.
With --output-directory the specified dir should exist already.
Perhaps new code can be added to check if the given path is a directory.


Olaf