From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 libdrm 1/7] configure: Support symbol visibility when available Date: Fri, 2 May 2014 16:12:58 +0200 Message-ID: <20140502141257.GB21515@ulmo> References: <1397043630-13972-1-git-send-email-thierry.reding@gmail.com> <1397043630-13972-2-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0235365831==" Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 90A136E3B2 for ; Fri, 2 May 2014 07:14:41 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id c41so3214793eek.3 for ; Fri, 02 May 2014 07:14:40 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Erik Faye-Lund Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org --===============0235365831== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA" Content-Disposition: inline --neYutvxvOLaeuPCA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 10, 2014 at 07:15:14PM +0200, Erik Faye-Lund wrote: > On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding = wrote: > > diff --git a/libdrm.h b/libdrm.h > > new file mode 100644 > > index 000000000000..23926e6f6741 > > --- /dev/null > > +++ b/libdrm.h > > @@ -0,0 +1,34 @@ > > +/* > > + * Copyright =C2=A9 2014 NVIDIA Corporation > > + * > > + * Permission is hereby granted, free of charge, to any person obtaini= ng a > > + * copy of this software and associated documentation files (the "Soft= ware"), > > + * to deal in the Software without restriction, including without limi= tation > > + * the rights to use, copy, modify, merge, publish, distribute, sublic= ense, > > + * and/or sell copies of the Software, and to permit persons to whom t= he > > + * Software is furnished to do so, subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be incl= uded in > > + * all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXP= RESS OR > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABI= LITY, > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT = SHALL > > + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAG= ES OR > > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWIS= E, > > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE = OR > > + * OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#ifndef LIBDRM_LIBDRM_H > > +#define LIBDRM_LIBDRM_H >=20 > LIBDRM_LIBDRM_H sounds a bit clunky to me. Why LIBDRM twice? The other > headers don't seem to prefix LIBDRM_ to their header-guards. In fact, > many of them don't even have header-guards. This was with the intention of marking it as an internal header file. So the LIBDRM_ prefix could be used consistently for all files that are not installed. xf86atomic.h uses that prefix as well. > Also, does these macro really warrant making a top-level, generically > named header? There isn't really another header file where this would fit. Others are either installed (and therefore shouldn't be exposing these macros) or have a very specific purpose (xf86atomic.h). Thierry --neYutvxvOLaeuPCA Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTY6fpAAoJEN0jrNd/PrOhHs8QAJa1WZqL47VDMqiaRbb3CF0S IMocPcyvowQj6rBoOF7oQvHCGbYWQx1L26w/ljHeWIPgx0PMqyc3FBGtVrKkFzbn bJP+ZTBx0czC3HapU5ucB3Dl/izcXZJicAT4BMr4sfDzcNtpxVOd/2t8B2EQx6jt IJn1+GAk6ez04RGwFhy4rlrQm7aPZKfyWbaNSZfGq93WApOVFlMatwV4zo8LRvR+ MjW+1UKyDXOS5fwxjtHwPpXZXmkm7+ojvNE77IqwHbkvpxLmY4vNO+RDwmCEep5U 3rgm+VcnaBRq7d5pIpcaplR8nfarbgkiU/uYxvOAFLU3sz3Xl6q4kjXH0zuaX+DK AbKK9cThTVo/l27GrEZbN6O5SIzJX0TfqeDF0afZDkJWPul9w2Phn0AkX7gRXiww BXPOHreGSnpjki2IY+t+B6rUgOjoWTJZ27/aWc7kEeyt5rWbrlDZRntjaB7s8LfE i8mmt1romPAvC3F/z5PGe5PA80Do7cS7dk4JYnhst9GSEBZSsXHFX8mBWtw2CJ1j tFeh1JVJ4FtV1KneSltbMTlB8h+aWqngPOueJoUjtlQF1z55+JElzuGfTvXVhHk3 Es0gsf7WXH9wBoGVY8wgQavrLJCQK0cElcM4S2D/XFf+DKvz46GP1d7ImP5R//kz FY445BNileHzZS2u/Q/r =bhvY -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA-- --===============0235365831== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0235365831==--