From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 libdrm 5/7] tegra: Add helper library for tests Date: Fri, 2 May 2014 16:47:01 +0200 Message-ID: <20140502144659.GF21515@ulmo> References: <1397043630-13972-1-git-send-email-thierry.reding@gmail.com> <1397043630-13972-6-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1218495556==" Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CF8B6E545 for ; Fri, 2 May 2014 07:48:46 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id e53so3226416eek.8 for ; Fri, 02 May 2014 07:48:43 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Erik Faye-Lund Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org --===============1218495556== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xkXJwpr35CY/Lc3I" Content-Disposition: inline --xkXJwpr35CY/Lc3I Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 28, 2014 at 09:44:35PM +0200, Erik Faye-Lund wrote: > On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding = wrote: > > From: Thierry Reding > > > > This library provides helpers for common functionality needed by test > > programs. > > > > Signed-off-by: Thierry Reding > > --- > > Changes in v2: > > - fix a couple of memory leaks and get rid of some unneeded code > > > > tests/tegra/Makefile.am | 10 +- > > tests/tegra/drm-test-tegra.c | 137 ++++++++++++++++++++++++ > > tests/tegra/drm-test-tegra.h | 55 ++++++++++ > > tests/tegra/drm-test.c | 248 +++++++++++++++++++++++++++++++++++= ++++++++ > > tests/tegra/drm-test.h | 72 +++++++++++++ > > 5 files changed, 521 insertions(+), 1 deletion(-) > > create mode 100644 tests/tegra/drm-test-tegra.c > > create mode 100644 tests/tegra/drm-test-tegra.h > > create mode 100644 tests/tegra/drm-test.c > > create mode 100644 tests/tegra/drm-test.h > > > > diff --git a/tests/tegra/Makefile.am b/tests/tegra/Makefile.am > > index 8b481bde4f11..e468029d152e 100644 > > --- a/tests/tegra/Makefile.am > > +++ b/tests/tegra/Makefile.am > > @@ -5,9 +5,17 @@ AM_CPPFLAGS =3D \ > > > > AM_CFLAGS =3D -Wall -Werror > > > > +noinst_LTLIBRARIES =3D libdrm-test.la > > +libdrm_test_la_SOURCES =3D \ > > + drm-test.c \ > > + drm-test.h \ > > + drm-test-tegra.c \ > > + drm-test-tegra.h > > + > > LDADD =3D \ > > ../../tegra/libdrm_tegra.la \ > > - ../../libdrm.la > > + ../../libdrm.la \ > > + libdrm-test.la > > >=20 > Hmm, I need the following on top to please the linker: >=20 > diff --git a/tests/tegra/Makefile.am b/tests/tegra/Makefile.am > index 286af4b..88230c0 100644 > --- a/tests/tegra/Makefile.am > +++ b/tests/tegra/Makefile.am > @@ -14,8 +14,8 @@ libdrm_test_la_SOURCES =3D \ >=20 > LDADD =3D \ > ../../tegra/libdrm_tegra.la \ > - ../../libdrm.la \ > - libdrm-test.la > + libdrm-test.la \ > + ../../libdrm.la >=20 > TESTS =3D \ > openclose \ Yeah, this was reported by pretty much everybody who tested this. And I have no setup where I could reproduce it. I eventually managed to trigger a similar error by explicitly passing both -Wl,--as-needed and -Wl,--no-copy-dt-needed-entries in LDFLAGS at configure time. I now have a version that builds with or without these flags, so I hope that everyone will now be happy. Thierry --xkXJwpr35CY/Lc3I Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTY6/jAAoJEN0jrNd/PrOhHusP/RZXazERclIAtm0kVS/E6r84 y1SA8WE6Jq3YBd8aTYZpRPPdsnNq9wfVrLC0gwYhXjMhJKm4SlZe2Zc2xOusISr+ ZGPW9xht12edvbJhtHpVIHId9gWDwxH6IZaLmnmwyZKe+QSFvfqtIpg4tCrrg6oK r5QuITE8XRnL9E3uwi7y/V/RsTBr0r8kqm7ZE/bYNtzzXdUC41epptVEXAlj1OIy 7QhoT4QiAu3PwXLVWsoL0lgsCSwWjRPbogtt1/MBsdD7txf7V+oDynOyDTby0OCW Zo/2SZT7ss7fBkOni7n4MuxmlIWkJrgzD1W7muGwEWblIOf+Ge6glm2sXE0ZBean JQOY7d7GiDeqqxwPMgSxDwNeYcD1R8c/y2/SvoRyvtrVza3o/yKMt4eWf2zo01Ai GRuWvhD1sHlzoDHOvxWj/x2B64NuBD7K22qTdaJWaKzB0Wn/kh3QcSPOcy2p/onl 42KYQF+TIPrnLqzU7yJ+EFeufptN/QbP2L2WLBUbal9KJ9IebK9pwo+/ifDqYkUj 8PbeKg+FGdhK6RUIgJs6y/wndwyFWLEHGJ6YzHTdqze5+xaXWeIxYbk5Z1tCvDXq F5LUKtMo0CYOljaZzdqiaQWmM/kb0MF/OMbwQY5EX5cx6RKKT4EKaxZIjHrKiLhm EDCcl82Vn6N6vGXIHS02 =N7lh -----END PGP SIGNATURE----- --xkXJwpr35CY/Lc3I-- --===============1218495556== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1218495556==--