From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Nicholas Mc Guire <der.herr@hofr.at>,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH RT 1/3] rt: Move migrate_disable up in trylocks
Date: Fri, 2 May 2014 17:31:53 +0200 [thread overview]
Message-ID: <20140502153153.GG9178@linutronix.de> (raw)
In-Reply-To: <20140501005004.241785945@goodmis.org>
* Steven Rostedt | 2014-04-30 20:47:58 [-0400]:
>From: Steven Rostedt <rostedt@goodmis.org>
>
>The changes to move the migrate_disable() down in the trylocks()
>caused race conditions to appear in the cpu hotplug code. The
>migrate disables must be done before any of the rtmutexes are
>taken, otherwise a lock may be held that prevents hotplug from
>moving forward.
>
>Link: http://lkml.kernel.org/r/20140429201308.63292691@gandalf.local.home
Okay. I am taking a modified version (so it applies) of this into v3.14
tree. Mike also suggested to drop
migrate_disable-pushd-down-in-atomic_dec_and_spin_lo.patch because we
which is basicaly the some thing. And then we have
migrate_disable-pushd-down-in-rt_spin_trylock_irqsav.patch which we
could drop as well for the same reason.
Sebastian
next prev parent reply other threads:[~2014-05-02 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 0:47 [PATCH RT 0/3] Linux 3.12.15-rt26-rc1 Steven Rostedt
2014-05-01 0:47 ` [PATCH RT 1/3] rt: Move migrate_disable up in trylocks Steven Rostedt
2014-05-02 7:11 ` Sebastian Andrzej Siewior
2014-05-02 13:06 ` Steven Rostedt
2014-05-02 15:31 ` Sebastian Andrzej Siewior [this message]
2014-05-01 0:47 ` [PATCH RT 2/3] net: gianfar: Fix missing return of gfar_clean_tx_ring() Steven Rostedt
2014-05-01 0:48 ` [PATCH RT 3/3] Linux 3.12.15-rt26-rc1 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502153153.GG9178@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=C.Emde@osadl.org \
--cc=der.herr@hofr.at \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.