From: Vinod Koul <vinod.koul@intel.com>
To: Alexander Popov <a13xp0p0v88@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Arnd Bergmann <arnd@arndb.de>, Gerhard Sittig <gsi@denx.de>,
Andy Shevchenko <andriy.shevchenko@linux.jf.intel.com>,
dmaengine@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Anatolij Gustschin <agust@denx.de>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH RFC v12 4/7] dma: mpc512x: fix freeing resources in mpc_dma_probe() and mpc_dma_remove()
Date: Fri, 2 May 2014 22:37:33 +0530 [thread overview]
Message-ID: <20140502170733.GN32284@intel.com> (raw)
In-Reply-To: <1398261209-5578-5-git-send-email-a13xp0p0v88@gmail.com>
On Wed, Apr 23, 2014 at 05:53:26PM +0400, Alexander Popov wrote:
> Fix mpc_dma_probe() error path and mpc_dma_remove(): manually free IRQs and
> dispose IRQ mappings before devm_* takes care of other resources.
> Moreover replace devm_request_irq() with request_irq() since there is no need
> to use it because the original code always frees IRQ manually with
> devm_free_irq(). Replace devm_free_irq() with free_irq() accordingly.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2014-05-02 17:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 13:53 [PATCH RFC v12 0/7] MPC512x DMA slave s/g support, OF DMA lookup Alexander Popov
2014-04-23 13:53 ` Alexander Popov
2014-04-23 13:53 ` [PATCH RFC v12 1/7] dma: mpc512x: reorder mpc8308 specific instructions Alexander Popov
2014-05-02 17:06 ` Vinod Koul
2014-04-23 13:53 ` [PATCH RFC v12 2/7] dma: mpc512x: separate 'compatible' values for MPC512x and MPC8308 Alexander Popov
2014-04-23 13:53 ` Alexander Popov
2014-05-02 17:07 ` Vinod Koul
2014-05-02 17:07 ` Vinod Koul
2014-04-23 13:53 ` [PATCH RFC v12 3/7] dma: mpc512x: add support for peripheral transfers Alexander Popov
2014-05-02 17:03 ` Vinod Koul
2014-05-08 9:49 ` Alexander Popov
2014-05-21 3:14 ` Vinod Koul
2014-04-23 13:53 ` [PATCH RFC v12 4/7] dma: mpc512x: fix freeing resources in mpc_dma_probe() and mpc_dma_remove() Alexander Popov
2014-05-02 17:07 ` Vinod Koul [this message]
2014-04-23 13:53 ` [PATCH RFC v12 5/7] dma: of: add common xlate function for matching by channel id Alexander Popov
2014-04-23 13:53 ` Alexander Popov
2014-05-02 17:04 ` Vinod Koul
2014-05-02 17:04 ` Vinod Koul
2014-04-23 13:53 ` [PATCH RFC v12 6/7] dma: mpc512x: add device tree binding document Alexander Popov
2014-04-23 13:53 ` Alexander Popov
2014-04-23 13:53 ` [PATCH RFC v12 7/7] dma: mpc512x: register for device tree channel lookup Alexander Popov
2014-04-23 13:53 ` Alexander Popov
2014-04-30 5:46 ` [PATCH RFC v12 0/7] MPC512x DMA slave s/g support, OF DMA lookup Alexander Popov
2014-04-30 5:46 ` Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502170733.GN32284@intel.com \
--to=vinod.koul@intel.com \
--cc=a13xp0p0v88@gmail.com \
--cc=agust@denx.de \
--cc=andriy.shevchenko@linux.jf.intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gsi@denx.de \
--cc=lars@metafoo.de \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.