From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 08/12] boot/syslinux: bump version
Date: Sat, 3 May 2014 22:20:02 +0200 [thread overview]
Message-ID: <20140503202002.GH10671@free.fr> (raw)
In-Reply-To: <87fvkqmxqy.fsf@dell.be.48ers.dk>
Peter, All,
On 2014-05-03 22:08 +0200, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > This new version has a very, very weird build system. There are different
> > images that syslinux can now build:
> > - the plain legacy-bios images we already supported previously
> > - two new EFI32 and EFI64 applications
>
> > To build one or the other, the Makefile accepts one or more of:
> > make (bios|efi32|efi64)
>
> > Specify all of them, and it builds all. Specify 'install', and it installs
> > all of them, as one may expect.
>
> > Still a regular behaviour, is to build only a subset (down to one):
> > make bios <-- builds just the legacy-bios images
> > make efi32 bios <-- builds just the legacy-bios and efi32 images
>
> > Where it gets weird is the install procedure. Can you guess how it's done?
> > Hint: the syslinux guys have invented the multiple-argument parsing in
> > pure Makefiles. To build then install only the bios images, one would do:
> > make bios
> > make bios install
>
> > Yep, that's it. make bios install. Two arguments, one action.
>
> > That makes for some funky workarounds in our install procedure...
>
> Is that so odd? If you don't have an explicit configure step, then there
> isn't really anything for the install step to know what configuration
> you have built (besides looking for what binaries are available).
That's not really the point.
The point is that, to tell what to install, you have to tell it as a
_separate_ make argument.
A bit like if you were doing:
make bios
make install-bios
But that last part is in fact spelt:
make install bios (or : make bios install)
Then, internally, the Makefile will look at the MAKECMDGOALS to decide
what to do. If none of {bios,efi32,efi64} are specified, it calls itself
back with all on the command line. If one or more are specified, it uses
that list (called FRIMWARE_LIST) to do what it as to do with it (explained
below).
Then, it also look at the other MAKECMDGOALS to see what it has to do:
build or install. If nothing is specified (except the bios/efi32/efi64
targets), then it builds the targets in FIRMWARE_LIST, otherwise it
installs the targets in FIRMWARE_LIST.
But our install command is not so funky, indeed. The first time I wrote
it, it was way funkier. I just forgot to cool down that part in the
commit log.
> Committed this and the rest of the series, thanks.
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-05-03 20:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 17:10 [Buildroot] [PATCH 0/12 v3] Bump and improve syslinux (branch yem/syslinux) Yann E. MORIN
2014-05-02 17:10 ` [Buildroot] [PATCH 01/12] boot/syslinux: needs an ia32-capable compiler Yann E. MORIN
2014-05-03 19:38 ` Peter Korsgaard
2014-05-02 17:10 ` [Buildroot] [PATCH 02/12] boot/syslinux: prepare to install non-core images Yann E. MORIN
2014-05-02 17:10 ` [Buildroot] [PATCH 03/12] boot/syslinux: make the sub-options a choice Yann E. MORIN
2014-05-02 17:10 ` [Buildroot] [PATCH 04/12] boot/syslinux: rewrite options prompts Yann E. MORIN
2014-05-02 17:10 ` [Buildroot] [PATCH 05/12] boot/syslinux: move comments out of define-block Yann E. MORIN
2014-05-03 19:39 ` Peter Korsgaard
2014-05-02 17:10 ` [Buildroot] [PATCH 06/12] package/ucl: new package Yann E. MORIN
2014-05-03 19:48 ` Peter Korsgaard
2014-05-02 17:10 ` [Buildroot] [PATCH 07/12] package/upx: " Yann E. MORIN
2014-05-03 19:48 ` Peter Korsgaard
2014-05-02 17:10 ` [Buildroot] [PATCH 08/12] boot/syslinux: bump version Yann E. MORIN
2014-05-03 20:08 ` Peter Korsgaard
2014-05-03 20:20 ` Yann E. MORIN [this message]
2014-05-02 17:10 ` [Buildroot] [PATCH 09/12] boot/syslinux: add option to install the EFI image Yann E. MORIN
2014-05-02 17:10 ` [Buildroot] [PATCH 10/12] boot/syslinux: add an option to install an MBR blob Yann E. MORIN
2014-05-02 17:10 ` [Buildroot] [PATCH 11/12] boot/syslinux: add option to install c32 modules Yann E. MORIN
2014-05-03 20:05 ` Peter Korsgaard
2014-05-03 20:08 ` Yann E. MORIN
2014-05-02 17:10 ` [Buildroot] [PATCH 12/12] boot/syslinux: install in a sub-dir of $(BINARIES_DIR) Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140503202002.GH10671@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.