From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon Date: Sat, 3 May 2014 18:07:31 -0400 Message-ID: <20140503220731.GA10927@kroah.com> References: <1397859600-11507-1-git-send-email-robherring2@gmail.com> <1397859600-11507-4-git-send-email-robherring2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:58475 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbaEDAv4 (ORCPT ); Sat, 3 May 2014 20:51:56 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Rob Herring Cc: Yinghai Lu , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , "linux-serial@vger.kernel.org" , Jiri Slaby , Catalin Marinas , Russell King , Will Deacon , Arnd Bergmann , Andrew Morton On Mon, Apr 28, 2014 at 06:20:53PM -0500, Rob Herring wrote: > On Sat, Apr 26, 2014 at 1:19 AM, Yinghai Lu wrote: > > On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring wrote: > >> From: Rob Herring > >> > >> With the generic earlycon infrastructure in place, convert the 8250 > >> early console to use it. > >> > >> Signed-off-by: Rob Herring > >> Cc: Greg Kroah-Hartman > >> Cc: Jiri Slaby > >> --- > >> drivers/tty/serial/8250/8250_early.c | 138 ++++------------------------------- > >> drivers/tty/serial/8250/Kconfig | 1 + > >> 2 files changed, 16 insertions(+), 123 deletions(-) > > > > Hi Greg, Rob > > > > This one in tty-next breaks booting: "console=uart8250,io,0x3f8,115200". > > No early console and regular console anymore. > > > > It should produce "early con and regular con". > > This is what I get for running checkpatch and converting > simple_strtoul to kstrto* which are not so equivalent. kstrto* will > not convert things such as 115200n8 to a number. > > Greg, Do you want a fix or for me to respin the series? The fix looks like this: As this is in my tree now (right?), I need a fix to apply to it. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Sat, 3 May 2014 18:07:31 -0400 Subject: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon In-Reply-To: References: <1397859600-11507-1-git-send-email-robherring2@gmail.com> <1397859600-11507-4-git-send-email-robherring2@gmail.com> Message-ID: <20140503220731.GA10927@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 28, 2014 at 06:20:53PM -0500, Rob Herring wrote: > On Sat, Apr 26, 2014 at 1:19 AM, Yinghai Lu wrote: > > On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring wrote: > >> From: Rob Herring > >> > >> With the generic earlycon infrastructure in place, convert the 8250 > >> early console to use it. > >> > >> Signed-off-by: Rob Herring > >> Cc: Greg Kroah-Hartman > >> Cc: Jiri Slaby > >> --- > >> drivers/tty/serial/8250/8250_early.c | 138 ++++------------------------------- > >> drivers/tty/serial/8250/Kconfig | 1 + > >> 2 files changed, 16 insertions(+), 123 deletions(-) > > > > Hi Greg, Rob > > > > This one in tty-next breaks booting: "console=uart8250,io,0x3f8,115200". > > No early console and regular console anymore. > > > > It should produce "early con and regular con". > > This is what I get for running checkpatch and converting > simple_strtoul to kstrto* which are not so equivalent. kstrto* will > not convert things such as 115200n8 to a number. > > Greg, Do you want a fix or for me to respin the series? The fix looks like this: As this is in my tree now (right?), I need a fix to apply to it. thanks, greg k-h