From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH V2] xfs: truncate_setsize should be outside transactions
Date: Sun, 4 May 2014 10:06:18 +1000 [thread overview]
Message-ID: <20140504000618.GK26353@dastard> (raw)
In-Reply-To: <20140503151601.GB28608@infradead.org>
On Sat, May 03, 2014 at 08:16:01AM -0700, Christoph Hellwig wrote:
> On Sat, May 03, 2014 at 09:23:39AM +1000, Dave Chinner wrote:
> > before we get to the transaction that can fail:
> > block_truncate_page() zeroes the tail of the page cache page. Hence
> > if the transaction reservation fails, we've already trashed the file
> > data - we may as well finish off the job and at least make it look
> > like the truncate succeeded from a user point of view. They then get
> > a ENOMEM error (only non-fatal error that can come from
> > xfs_trans_reserve) and try the truncate again....
>
> I don't think we can even get the ENOMEM.
We can - we pass KM_MAYFAIL to xlog_ticket_alloc() from
xfs_log_reserve().
> But yeah, I guess
> we want something like the old version, with comments explaining exactly
> we we have this order.
I'll send another version of the first patch with an expanded
comment.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-04 0:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 22:39 [PATCH] xfs: truncate_setsize should be outside transactions Dave Chinner
2014-05-02 4:54 ` Christoph Hellwig
2014-05-02 5:00 ` Christoph Hellwig
2014-05-02 6:47 ` Dave Chinner
2014-05-02 7:00 ` [PATCH V2] " Dave Chinner
2014-05-02 10:08 ` Christoph Hellwig
2014-05-02 23:23 ` Dave Chinner
2014-05-03 15:16 ` Christoph Hellwig
2014-05-04 0:06 ` Dave Chinner [this message]
2014-05-05 5:19 ` [PATCH V3] " Dave Chinner
2014-05-06 7:52 ` Christoph Hellwig
2014-05-02 12:50 ` [PATCH V2] " Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140504000618.GK26353@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.