All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Kepplinger <martink@posteo.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8821ae: mark pointer in pci_iounmap as __iomem
Date: Sat, 3 May 2014 20:26:17 -0400	[thread overview]
Message-ID: <20140504002617.GA16403@kroah.com> (raw)
In-Reply-To: <1399129848-1833-1-git-send-email-martink@posteo.de>

On Sat, May 03, 2014 at 05:10:48PM +0200, Martin Kepplinger wrote:
> pci_iounmap is used that way in drivers/net/wireless/rtlwifi and this
> fixes sparse warnings.
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
>  drivers/staging/rtl8821ae/pci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae/pci.c
> index a562aa6..d934ecb 100644
> --- a/drivers/staging/rtl8821ae/pci.c
> +++ b/drivers/staging/rtl8821ae/pci.c
> @@ -2416,7 +2416,7 @@ fail3:
>  	ieee80211_free_hw(hw);
>  
>  	if (rtlpriv->io.pci_mem_start != 0)
> -		pci_iounmap(pdev, (void *)rtlpriv->io.pci_mem_start);
> +		pci_iounmap(pdev, (void __iomem *)rtlpriv->io.pci_mem_start);

Shouldn't pci_mem_start be a __iomem pointer instead?

thanks,

greg k-h

  reply	other threads:[~2014-05-04  1:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-03 15:10 [PATCH] staging: rtl8821ae: mark pointer in pci_iounmap as __iomem Martin Kepplinger
2014-05-04  0:26 ` Greg KH [this message]
2014-05-04 12:22   ` [PATCH v2] staging: rtl8821ae: mark pci_mem_start (and _end) " Martin Kepplinger
2014-05-23 12:33     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140504002617.GA16403@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martink@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.