All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, Seunghun Lee <waydi1@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: fix missing a blank line after declarations
Date: Mon, 5 May 2014 12:59:35 +0300	[thread overview]
Message-ID: <20140505095935.GO26890@mwanda> (raw)
In-Reply-To: <20140503234326.GA30117@kroah.com>

On Sat, May 03, 2014 at 07:43:26PM -0400, Greg KH wrote:
> On Tue, Apr 29, 2014 at 08:32:21PM +0300, Dan Carpenter wrote:
> > On Wed, Apr 30, 2014 at 01:59:12AM +0900, Seunghun Lee wrote:
> > > This patch fixes "Missing a blank line after declarations" warnings.
> > > 
> > > Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> > 
> > Quite a few of these are false checkpatch.pl false positives.  Just
> > ignore the false positives.
> 
> Really?  It looks good to me, what am I missing?
> 

Gar.  You're right.  In my head I remember seeing a bunch of false
positives but now that I'm looking at it again I'm not sure what I was
talking about.

regards,
dan carpenter


  reply	other threads:[~2014-05-05  9:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29 16:59 [PATCH] staging: android: fix missing a blank line after declarations Seunghun Lee
2014-04-29 17:32 ` Dan Carpenter
2014-05-03 23:43   ` Greg KH
2014-05-05  9:59     ` Dan Carpenter [this message]
2014-05-05 19:51       ` Joe Perches
2014-05-05 20:12         ` [PATCH] checkpatch: Improve missing blank line after declarations test Joe Perches
2014-05-05 22:15           ` Andrew Morton
2014-05-05 22:35             ` Joe Perches
2014-05-05 22:42               ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140505095935.GO26890@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=waydi1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.