From: Dan Carpenter <dan.carpenter@oracle.com>
To: Martin Kepplinger <martink@posteo.de>
Cc: gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, lidza.louina@gmail.com
Subject: Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
Date: Mon, 5 May 2014 15:36:03 +0300 [thread overview]
Message-ID: <20140505123603.GQ26890@mwanda> (raw)
In-Reply-To: <53677D1D.5000204@posteo.de>
On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote:
> Am 2014-05-05 13:35, schrieb Dan Carpenter:
> > On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
> >> Use dev_err() instead of printk() and remove "dgnc:" from the message.
> >> This should provide userspace with more useful information and use
> >> the common kernel coding style.
> >>
> >
> > Whenever I see a "RESEND" in a subject and no explanation then it means
> > our development process has broken down. Meanwhile this is the first
> > time I have seen this patch so the problem is not on our side.
> >
> > regards,
> > dan carpenter
> >
>
> I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week
> or so. I don't see any breakdown.
What I'm saying is just put an explanation after the --- cut off so we
know what you did wrong the first time.
Signed-off-by ...
---
Resending because I sent it to the wrong email list the first time.
Oops! Next time I will use get_maintainer.pl, I promise!
Just a simple explanation like that is ok.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-05 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 9:43 [PATCH] staging: dgnc: use dev_err() instead of printk() Martin Kepplinger
2014-04-29 9:54 ` Martin Kepplinger
2014-05-05 10:29 ` [RESEND PATCH] " Martin Kepplinger
2014-05-05 11:35 ` Dan Carpenter
2014-05-05 11:59 ` Martin Kepplinger
2014-05-05 12:36 ` Dan Carpenter [this message]
2014-05-05 12:44 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505123603.GQ26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.