From: Matthew Wilcox <willy@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Chuck Lever <chuck.lever@oracle.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] posix_acl: handle NULL ACL in posix_acl_equiv_mode
Date: Mon, 5 May 2014 09:57:19 -0400 [thread overview]
Message-ID: <20140505135719.GE5929@linux.intel.com> (raw)
In-Reply-To: <1399201412-17938-1-git-send-email-hch@lst.de>
On Sun, May 04, 2014 at 01:03:32PM +0200, Christoph Hellwig wrote:
> Various filesystems don't bother checking for a NULL ACL in
> posix_acl_equiv_mode, and thus can dereference a NULL pointer when it
> gets passed one. This usually happens from the NFS server, as the ACL tools
> never pass a NULL ACL, but instead of one representing the mode bits.
>
> Instead of adding boilerplat to all filesystems put this check into one place,
> which will allow us to remove the check from other filesystems as well later
> on.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Ben Greear <greearb@candelatech.com>
> Reported-by: Marco Munderloh <munderl@tnt.uni-hannover.de>,
> Cc: Chuck Lever <chuck.lever@oracle.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
next prev parent reply other threads:[~2014-05-05 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 11:03 [PATCH] posix_acl: handle NULL ACL in posix_acl_equiv_mode Christoph Hellwig
2014-05-05 13:57 ` Matthew Wilcox [this message]
2014-05-05 14:59 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505135719.GE5929@linux.intel.com \
--to=willy@linux.intel.com \
--cc=chuck.lever@oracle.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.