From: Stephen Hemminger <stephen@networkplumber.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Adam Lee <adam.lee@canonical.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 1/3] rtlwifi: make MSI support a module parameter
Date: Mon, 5 May 2014 15:40:37 -0700 [thread overview]
Message-ID: <20140505154037.19620ac2@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <5367A690.7010305@lwfinger.net>
On Mon, 05 May 2014 09:56:16 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 05/05/2014 03:33 AM, Adam Lee wrote:
> > This makes MSI support a module parameter, for debugging and workaround
> > convenience.
> >
> > Signed-off-by: Adam Lee <adam.lee@canonical.com>
>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net> (for all 3 patches)
>
> I would have made the default for the MSI option to be true, but that is a
> matter of preference, and only experience would show which default leads to the
> fewer failures. On my laptop, both rtl8188ee and rtl8723be work either way. I am
> now working on a driver for the RTL8192EE that also can use MSI - that has only
> been tested with the option on.
>
> Larry
Standard practice is to assume MSI is available, and let the quirks
in the PCI subsystem reject the request to enable MSI.
Also other drivers have a 'disable_msi' module parameter why not follow
their example.
next prev parent reply other threads:[~2014-05-05 22:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 8:33 [PATCH 1/3] rtlwifi: make MSI support a module parameter Adam Lee
2014-05-05 8:33 ` Adam Lee
2014-05-05 8:33 ` [PATCH 2/3] rtlwifi: rtl8188ee: add msi " Adam Lee
2014-05-05 8:33 ` [PATCH 3/3] rtlwifi: rtl8723be: " Adam Lee
2014-05-05 8:33 ` Adam Lee
2014-05-05 14:56 ` [PATCH 1/3] rtlwifi: make MSI support a " Larry Finger
2014-05-05 22:40 ` Stephen Hemminger [this message]
2014-05-06 2:19 ` Adam Lee
2014-05-06 18:08 ` John W. Linville
2014-05-06 18:08 ` John W. Linville
2014-05-07 2:31 ` Adam Lee
2014-05-07 2:52 ` Adam Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505154037.19620ac2@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=Larry.Finger@lwfinger.net \
--cc=adam.lee@canonical.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.