All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, peterz@infradead.org,
	peter@hurleysoftware.com, jason.low2@hp.com, riel@redhat.com,
	alex.shi@linaro.org, paulmck@linux.vnet.ibm.com,
	akpm@linux-foundation.org, tglx@linutronix.de, walken@google.com,
	davidlohr@hp.com, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [tip:locking/core] rwsem: Add comments to explain the meaning of the rwsem's count field
Date: Mon, 5 May 2014 19:26:11 +0200	[thread overview]
Message-ID: <20140505172611.GA7154@gmail.com> (raw)
In-Reply-To: <1399305808.2970.186.camel@schen9-DESK>


* Tim Chen <tim.c.chen@linux.intel.com> wrote:

> On Mon, 2014-05-05 at 01:46 -0700, tip-bot for Tim Chen wrote:
> > Commit-ID:  3cf2f34e1a3d4d5ff209d087925cf950e52f4805
> > Gitweb:     http://git.kernel.org/tip/3cf2f34e1a3d4d5ff209d087925cf950e52f4805
> > Author:     Tim Chen <tim.c.chen@linux.intel.com>
> > AuthorDate: Fri, 2 May 2014 12:53:57 -0700
> > Committer:  Ingo Molnar <mingo@kernel.org>
> > CommitDate: Sun, 4 May 2014 20:34:26 +0200
> > 
> 
> Ingo,
> 
> Can you pick up this version of the patch instead.  I've updated the 
> comments to reflect all cases for which the rwsem's count is less 
> than WAITING_BIAS, as Peter has pointed out.

Please send a delta patch against the one I applied - and also the 
state diagram suggestion with Peter, once it's clear what form it 
should take. I've yet to see a state diagram that was inferior to 
equivalent textual description - is this case an exception to that?

Thanks,

	Ingo

  parent reply	other threads:[~2014-05-05 17:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02 19:53 [PATCH v2] rwsem: Comments to explain the meaning of the rwsem's count field Tim Chen
2014-05-05  8:46 ` [tip:locking/core] rwsem: Add comments " tip-bot for Tim Chen
2014-05-05 16:03   ` Tim Chen
2014-05-05 16:31     ` Peter Zijlstra
2014-05-05 16:59       ` Tim Chen
2014-05-05 17:26     ` Ingo Molnar [this message]
2014-05-05 18:21       ` Tim Chen
2014-05-05 18:27         ` Ingo Molnar
2014-05-05 22:51           ` Tim Chen
2014-05-06  2:30             ` Davidlohr Bueso
2014-05-14 14:27   ` Davidlohr Bueso
2014-05-14 14:53     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140505172611.GA7154@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@linaro.org \
    --cc=davidlohr@hp.com \
    --cc=hpa@zytor.com \
    --cc=jason.low2@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peter@hurleysoftware.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.