From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhP9L-0007Hl-Py for qemu-devel@nongnu.org; Mon, 05 May 2014 16:06:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhP9G-0000X1-O8 for qemu-devel@nongnu.org; Mon, 05 May 2014 16:06:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhP9G-0000Ww-Er for qemu-devel@nongnu.org; Mon, 05 May 2014 16:06:02 -0400 Date: Mon, 5 May 2014 23:04:52 +0300 From: "Michael S. Tsirkin" Message-ID: <20140505200452.GA8279@redhat.com> References: <1398200431-13494-1-git-send-email-hpoussin@reactos.org> <53655409.4080903@reactos.org> <20140505080110.GA11352@redhat.com> <5367EE6F.6040602@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <5367EE6F.6040602@reactos.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] i8259: don't abort when trying to use level sensitive irqs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Herv=E9?= Poussineau Cc: qemu-devel@nongnu.org, Anthony Liguori On Mon, May 05, 2014 at 10:02:55PM +0200, Herv=E9 Poussineau wrote: > Le lun. 05 mai 2014 10:01:10 CEST, Michael S. Tsirkin a =E9crit : > >On Sat, May 03, 2014 at 10:39:37PM +0200, Herv=E9 Poussineau wrote: > >>Ping. > >> > >>Le 22/04/2014 23:00, Herv=E9 Poussineau a =E9crit : > >>>This is a guest-triggerable error, as seen when using Xenix 2.3.4. > >>>Replace hw_error by LOG_UNIMPL, so that guests have at least a chanc= e to continue. > >>> > >>>Signed-off-by: Herv=E9 Poussineau > > > >Is it just "a chance" or does Xenix actually work well with this > >applied? >=20 > Yes, > With this patch, I can install and use Xenix 2.3.4a without any problem. > I can also start installation of Xenix 2.3.4q, but it fails due to > not finding an hard disk. >=20 > Regards, >=20 > Herv=E9 Thanks! I'll pick this patch up when I'm back online. > > > > > >>>--- > >>> hw/intc/i8259.c | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>>diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c > >>>index c6f248b..a069d04 100644 > >>>--- a/hw/intc/i8259.c > >>>+++ b/hw/intc/i8259.c > >>>@@ -265,7 +265,8 @@ static void pic_ioport_write(void *opaque, hwadd= r addr64, > >>> s->init4 =3D val & 1; > >>> s->single_mode =3D val & 2; > >>> if (val & 0x08) { > >>>- hw_error("level sensitive irq not supported"); > >>>+ qemu_log_mask(LOG_UNIMP, > >>>+ "i8259: level sensitive irq not suppo= rted\n"); > >>> } > >>> } else if (val & 0x08) { > >>> if (val & 0x04) { > >>> > > >=20