All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-core@lists.openembedded.org
Subject: Recipes erroneously marked as "commercial"?
Date: Tue, 06 May 2014 16:00:46 -0400	[thread overview]
Message-ID: <20140506200046.GC11339@denix.org> (raw)

So, long time ago we had a short list of "commercial" packages in a global 
variable COMMERCIAL_LICENSE:

COMMERCIAL_LICENSE ?= "lame gst-fluendo-mp3 libmad mpeg2dec ffmpeg qmmp"

Then, at some point, the packages that depend on commercial ones were added to 
the list, to allow wold builds to be successful:

http://cgit.openembedded.org/openembedded-core/commit/?id=c69453fe94a649c518b0e6d79616f05579b864ce

So, the list was appended with this:

COMMERCIAL_LICENSE_DEPENDEES ?= "gst-plugins-ugly libomxil gst-openmax"

Then, later on, the feature was changed from a global list to a per-recipe 
flags:

http://cgit.openembedded.org/openembedded-core/commit/?id=a2760661b8c7a4a1b6f2e556853b3a9ae38cbcb5
http://cgit.openembedded.org/openembedded-core/commit/?id=43410523a07d9eb52a7d57ae3dc1cc320cbbc6f9

And all those recipes got marked with LICENSE_FLAGS = "commercial" 
automatically, even if they are not really commercial.

The question is - should we clean those up now? I can send a quick patch, if 
my understanding above is correct.

-- 
Denys


             reply	other threads:[~2014-05-06 21:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 20:00 Denys Dmytriyenko [this message]
2014-05-06 20:19 ` Recipes erroneously marked as "commercial"? Sean Hudson
2014-05-06 20:54   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140506200046.GC11339@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.