Re: [PATCH] igt tests/gem_exec_params: Test for -EINVAL for invalid platform and ring when executing RS

From: Daniel Vetter <daniel@ffwll.ch>
To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] igt tests/gem_exec_params: Test for -EINVAL for invalid platform and ring when executing RS
Date: Wed, 7 May 2014 00:40:13 +0200	[thread overview]
Message-ID: <20140506224013.GI5730@phenom.ffwll.local> (raw)
In-Reply-To: <1399412453-28379-1-git-send-email-abdiel.janulgue@linux.intel.com>

On Wed, May 07, 2014 at 12:40:53AM +0300, Abdiel Janulgue wrote:
> Add test that makes sure RS bit only gets executed on BDW and
> on the render ring.
> 
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> ---
>  tests/gem_exec_params.c |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> index 769969d..a3f765b 100644
> --- a/tests/gem_exec_params.c
> +++ b/tests/gem_exec_params.c
> @@ -193,6 +193,17 @@ igt_main
>  		execbuf.num_cliprects = 0;
>  	}
>  
> +	igt_subtest("rs-not-gen8") {
> +                igt_require(intel_gen(devid) != 8);
> +                execbuf.flags = I915_EXEC_RENDER | I915_EXEC_RESOURCE_STREAMER;
> +                RUN_FAIL(EINVAL);
> +        }
> +
> +	igt_subtest("invalid-rs-ring") {
> +		execbuf.flags = I915_EXEC_RESOURCE_STREAMER;
> +		RUN_FAIL(EINVAL);

See Chris comment, but 0 is actually _not_ an invalid ring, but aliases
RCS. Yeah, we have a fun api. So this should actually suceed, at least on
bdw (and -EINVAL everywhere else).

So you need to explicitly test with some other ring like VCS
(I915_EXEC_BSD).
-Daniel

> +	}
> +
>  #define DIRT(name) \
>  	igt_subtest(#name "-dirt") { \
>  		execbuf.flags = 0; \
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch