All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: John Church <j.church@ymail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	georgiana.chelu93@gmail.com, waydi1@gmail.com
Subject: Re: [PATCH] Staging: android: fix coding style issue for Eudyptula Challenge in timed_gpio.c
Date: Tue, 6 May 2014 18:31:46 -0700	[thread overview]
Message-ID: <20140507013146.GA4245@kroah.com> (raw)
In-Reply-To: <536973DF.8010503@ymail.com>

On Wed, May 07, 2014 at 12:44:31AM +0100, John Church wrote:
> 

> Signed-off-by: John Church <j.church@ymail.com>


What coding style issue?

You need to be specific in your body of your email, and put a blank line
after the signed-off-by and before the patch, otherwise the tools can
complain.

And drop the Eudyptula challenge line in subject:, it's not needed at
all.

Can you redo this and resend?

thanks,

greg k-h

           reply	other threads:[~2014-05-07  1:31 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <536973DF.8010503@ymail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507013146.GA4245@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=georgiana.chelu93@gmail.com \
    --cc=j.church@ymail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=waydi1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.