From: Thierry Reding <thierry.reding@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Beniamino Galvani <b.galvani@gmail.com>,
linux-pwm@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pwm: spear: fix check on pwmchip_add() return value
Date: Wed, 7 May 2014 10:49:00 +0200 [thread overview]
Message-ID: <20140507084900.GE6362@ulmo> (raw)
In-Reply-To: <CAKohpomkrR715dhyZZQwu_-S6LHsYBOj9YsX9HR6PCMKkMdrVw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Wed, May 07, 2014 at 02:02:24PM +0530, Viresh Kumar wrote:
> On 7 May 2014 13:54, Thierry Reding <thierry.reding@gmail.com> wrote:
> > So the current code would run clk_unprepare() on success, but not on
> > failure. Does that cause any harm?
>
> Yeah, that would make the device unusable as clk_enable will always fail.
Hmm... so ever since this driver was merged in 3.8 it was completely
broken and nobody noticed? Interesting.
> > Is the device still usable after this?
>
> Yes, this will fix the bug.
>
> > I'm asking because I'm not sure if this is linux-next material
> > or should be a fix for 3.15 (and possibly backported to stable).
>
> IMO, it should be sent for stable: v3.8+
Since this was obviously broken since 3.8 and nobody noticed I wonder if
there's really an urgent need for this in stable.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-07 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 21:29 [PATCH] pwm: spear: fix check on pwmchip_add() return value Beniamino Galvani
2014-05-07 6:07 ` Viresh Kumar
2014-05-07 8:24 ` Thierry Reding
2014-05-07 8:32 ` Viresh Kumar
2014-05-07 8:49 ` Thierry Reding [this message]
2014-05-07 8:53 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507084900.GE6362@ulmo \
--to=thierry.reding@gmail.com \
--cc=b.galvani@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.