Re: [Qemu-devel] [RFC PATCH v2 05/16] Header/constant/types fixes for visitors

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Michael S. Tsirkin (mst@redhat.com) wrote:
> On Wed, Apr 23, 2014 at 05:37:38PM +0100, Dr. David Alan Gilbert (git) wrote:

<snip>

> > +typedef struct {
> > +    uint64_t addr;
> > +    uint16_t flags;
> > +    char     idstr[256];
> > +    char     ch;  /* Used for filled pages (normally 0 fill) */
> > +    size_t   len; /* Uses include xbzrle's data len */
> > +} ramsecentry_header;
> > +
> 
> 
> RamSecEntryHeader?

Fixed, thanks.

> and maybe we should make this 256 a named constant too.

It's 256 because the old format uses a byte as a length; I've commented
it.

Dave

--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK