* [PATCH V6 0/2] arm: dts: dra7: Updates for adding crossbar device
@ 2014-05-07 12:16 ` Sricharan R
0 siblings, 0 replies; 12+ messages in thread
From: Sricharan R @ 2014-05-07 12:16 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-doc, linux-arm-kernel, linux-omap,
linus.walleij, linux, tony, rnayak, marc.zyngier, grant.likely,
mark.rutland, tglx, galak, santosh.shilimkar, nm, bcousson,
robherring2
Cc: Sricharan R
Some socs have a large number of interrupts requests to service
the needs of its many peripherals and subsystems. All of the interrupt
requests lines from the subsystems are not needed at the same
time, so they have to be muxed to the controllers appropriately.
In such places a interrupt controllers are preceded by an
IRQ CROSSBAR that provides flexibility in muxing the device interrupt
requests to the controller inputs.
The dts file update to support the crossbar device and convert
peripheral irq numbers to crossbar number are added here.
This is a rebase on top of 3.15-rc4
This series depends on crossbar-driver-fixes sent below
http://marc.info/?l=linux-omap&m=139929963420299&w=2
[V6] Reordered patch 3 to patch 1 and
squashed patch 2 and 3 from V5 in to patch 2
Sricharan R (2):
arm: dts: dra7: Add routable-irqs property for gic node
arm: dts: dra7: Add crossbar device binding
arch/arm/boot/dts/dra7.dtsi | 109 +++++++++++++++++++++++++------------------
1 file changed, 63 insertions(+), 46 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH V6 0/2] arm: dts: dra7: Updates for adding crossbar device
@ 2014-05-07 12:16 ` Sricharan R
0 siblings, 0 replies; 12+ messages in thread
From: Sricharan R @ 2014-05-07 12:16 UTC (permalink / raw)
To: linux-arm-kernel
Some socs have a large number of interrupts requests to service
the needs of its many peripherals and subsystems. All of the interrupt
requests lines from the subsystems are not needed at the same
time, so they have to be muxed to the controllers appropriately.
In such places a interrupt controllers are preceded by an
IRQ CROSSBAR that provides flexibility in muxing the device interrupt
requests to the controller inputs.
The dts file update to support the crossbar device and convert
peripheral irq numbers to crossbar number are added here.
This is a rebase on top of 3.15-rc4
This series depends on crossbar-driver-fixes sent below
http://marc.info/?l=linux-omap&m=139929963420299&w=2
[V6] Reordered patch 3 to patch 1 and
squashed patch 2 and 3 from V5 in to patch 2
Sricharan R (2):
arm: dts: dra7: Add routable-irqs property for gic node
arm: dts: dra7: Add crossbar device binding
arch/arm/boot/dts/dra7.dtsi | 109 +++++++++++++++++++++++++------------------
1 file changed, 63 insertions(+), 46 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH V6 1/2] arm: dts: dra7: Add routable-irqs property for gic node
2014-05-07 12:16 ` Sricharan R
(?)
@ 2014-05-07 12:16 ` Sricharan R
-1 siblings, 0 replies; 12+ messages in thread
From: Sricharan R @ 2014-05-07 12:16 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-doc, linux-arm-kernel, linux-omap,
linus.walleij, linux, tony, rnayak, marc.zyngier, grant.likely,
mark.rutland, tglx, galak, santosh.shilimkar, nm, bcousson,
robherring2
Cc: Sricharan R
There is a IRQ crossbar device in the soc, which maps the
irq requests from the peripherals to the mpu interrupt
controller's inputs. The gic provides the support for such
IPs in the form of routable-irqs. So adding the property
here to gic node.
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Tested-by: Darren Etheridge <detheridge@ti.com>
Tested-by: Roger Quadros <rogerq@ti.com>
---
[V6] Reordered patch 3 from V5 to patch 1
arch/arm/boot/dts/dra7.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 149b550..52df16a 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -72,6 +72,7 @@
compatible = "arm,cortex-a15-gic";
interrupt-controller;
#interrupt-cells = <3>;
+ arm,routable-irqs = <192>;
reg = <0x48211000 0x1000>,
<0x48212000 0x1000>,
<0x48214000 0x2000>,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH V6 1/2] arm: dts: dra7: Add routable-irqs property for gic node
@ 2014-05-07 12:16 ` Sricharan R
0 siblings, 0 replies; 12+ messages in thread
From: Sricharan R @ 2014-05-07 12:16 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-doc, linux-arm-kernel, linux-omap,
linus.walleij, linux, tony, rnayak, marc.zyngier, grant.likely,
mark.rutland, tglx, galak, santosh.shilimkar, nm, bcousson,
robherring2
Cc: Sricharan R
There is a IRQ crossbar device in the soc, which maps the
irq requests from the peripherals to the mpu interrupt
controller's inputs. The gic provides the support for such
IPs in the form of routable-irqs. So adding the property
here to gic node.
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Tested-by: Darren Etheridge <detheridge@ti.com>
Tested-by: Roger Quadros <rogerq@ti.com>
---
[V6] Reordered patch 3 from V5 to patch 1
arch/arm/boot/dts/dra7.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 149b550..52df16a 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -72,6 +72,7 @@
compatible = "arm,cortex-a15-gic";
interrupt-controller;
#interrupt-cells = <3>;
+ arm,routable-irqs = <192>;
reg = <0x48211000 0x1000>,
<0x48212000 0x1000>,
<0x48214000 0x2000>,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH V6 1/2] arm: dts: dra7: Add routable-irqs property for gic node
@ 2014-05-07 12:16 ` Sricharan R
0 siblings, 0 replies; 12+ messages in thread
From: Sricharan R @ 2014-05-07 12:16 UTC (permalink / raw)
To: linux-arm-kernel
There is a IRQ crossbar device in the soc, which maps the
irq requests from the peripherals to the mpu interrupt
controller's inputs. The gic provides the support for such
IPs in the form of routable-irqs. So adding the property
here to gic node.
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Tested-by: Darren Etheridge <detheridge@ti.com>
Tested-by: Roger Quadros <rogerq@ti.com>
---
[V6] Reordered patch 3 from V5 to patch 1
arch/arm/boot/dts/dra7.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 149b550..52df16a 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -72,6 +72,7 @@
compatible = "arm,cortex-a15-gic";
interrupt-controller;
#interrupt-cells = <3>;
+ arm,routable-irqs = <192>;
reg = <0x48211000 0x1000>,
<0x48212000 0x1000>,
<0x48214000 0x2000>,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH V6 0/2] arm: dts: dra7: Updates for adding crossbar device
2014-05-07 12:16 ` Sricharan R
(?)
@ 2014-05-07 14:56 ` Darren Etheridge
-1 siblings, 0 replies; 12+ messages in thread
From: Darren Etheridge @ 2014-05-07 14:56 UTC (permalink / raw)
To: Sricharan R
Cc: linux-kernel, devicetree, linux-doc, linux-arm-kernel, linux-omap,
linus.walleij, linux, tony, rnayak, marc.zyngier, grant.likely,
mark.rutland, tglx, galak, santosh.shilimkar, nm, bcousson,
robherring2
Sricharan R <r.sricharan@ti.com> wrote on Wed [2014-May-07 17:46:36 +0530]:
> Some socs have a large number of interrupts requests to service
> the needs of its many peripherals and subsystems. All of the interrupt
> requests lines from the subsystems are not needed at the same
> time, so they have to be muxed to the controllers appropriately.
> In such places a interrupt controllers are preceded by an
> IRQ CROSSBAR that provides flexibility in muxing the device interrupt
> requests to the controller inputs.
>
> The dts file update to support the crossbar device and convert
> peripheral irq numbers to crossbar number are added here.
>
> This is a rebase on top of 3.15-rc4
>
> This series depends on crossbar-driver-fixes sent below
> http://marc.info/?l=linux-omap&m=139929963420299&w=2
>
> [V6] Reordered patch 3 to patch 1 and
> squashed patch 2 and 3 from V5 in to patch 2
>
> Sricharan R (2):
> arm: dts: dra7: Add routable-irqs property for gic node
> arm: dts: dra7: Add crossbar device binding
>
Just for thoroughness I dropped the previous 3 patch series from my
build and replaced with this two patch series. Everything still works
with my test setup so I consider these patches good.
Darren
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH V6 0/2] arm: dts: dra7: Updates for adding crossbar device
@ 2014-05-07 14:56 ` Darren Etheridge
0 siblings, 0 replies; 12+ messages in thread
From: Darren Etheridge @ 2014-05-07 14:56 UTC (permalink / raw)
To: Sricharan R
Cc: linux-kernel, devicetree, linux-doc, linux-arm-kernel, linux-omap,
linus.walleij, linux, tony, rnayak, marc.zyngier, grant.likely,
mark.rutland, tglx, galak, santosh.shilimkar, nm, bcousson,
robherring2
Sricharan R <r.sricharan@ti.com> wrote on Wed [2014-May-07 17:46:36 +0530]:
> Some socs have a large number of interrupts requests to service
> the needs of its many peripherals and subsystems. All of the interrupt
> requests lines from the subsystems are not needed at the same
> time, so they have to be muxed to the controllers appropriately.
> In such places a interrupt controllers are preceded by an
> IRQ CROSSBAR that provides flexibility in muxing the device interrupt
> requests to the controller inputs.
>
> The dts file update to support the crossbar device and convert
> peripheral irq numbers to crossbar number are added here.
>
> This is a rebase on top of 3.15-rc4
>
> This series depends on crossbar-driver-fixes sent below
> http://marc.info/?l=linux-omap&m=139929963420299&w=2
>
> [V6] Reordered patch 3 to patch 1 and
> squashed patch 2 and 3 from V5 in to patch 2
>
> Sricharan R (2):
> arm: dts: dra7: Add routable-irqs property for gic node
> arm: dts: dra7: Add crossbar device binding
>
Just for thoroughness I dropped the previous 3 patch series from my
build and replaced with this two patch series. Everything still works
with my test setup so I consider these patches good.
Darren
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH V6 0/2] arm: dts: dra7: Updates for adding crossbar device
@ 2014-05-07 14:56 ` Darren Etheridge
0 siblings, 0 replies; 12+ messages in thread
From: Darren Etheridge @ 2014-05-07 14:56 UTC (permalink / raw)
To: linux-arm-kernel
Sricharan R <r.sricharan@ti.com> wrote on Wed [2014-May-07 17:46:36 +0530]:
> Some socs have a large number of interrupts requests to service
> the needs of its many peripherals and subsystems. All of the interrupt
> requests lines from the subsystems are not needed at the same
> time, so they have to be muxed to the controllers appropriately.
> In such places a interrupt controllers are preceded by an
> IRQ CROSSBAR that provides flexibility in muxing the device interrupt
> requests to the controller inputs.
>
> The dts file update to support the crossbar device and convert
> peripheral irq numbers to crossbar number are added here.
>
> This is a rebase on top of 3.15-rc4
>
> This series depends on crossbar-driver-fixes sent below
> http://marc.info/?l=linux-omap&m=139929963420299&w=2
>
> [V6] Reordered patch 3 to patch 1 and
> squashed patch 2 and 3 from V5 in to patch 2
>
> Sricharan R (2):
> arm: dts: dra7: Add routable-irqs property for gic node
> arm: dts: dra7: Add crossbar device binding
>
Just for thoroughness I dropped the previous 3 patch series from my
build and replaced with this two patch series. Everything still works
with my test setup so I consider these patches good.
Darren
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH V6 0/2] arm: dts: dra7: Updates for adding crossbar device
2014-05-07 14:56 ` Darren Etheridge
(?)
@ 2014-05-07 15:29 ` Nishanth Menon
-1 siblings, 0 replies; 12+ messages in thread
From: Nishanth Menon @ 2014-05-07 15:29 UTC (permalink / raw)
To: Darren Etheridge, Sricharan R
Cc: linux-kernel, devicetree, linux-doc, linux-arm-kernel, linux-omap,
linus.walleij, linux, tony, rnayak, marc.zyngier, grant.likely,
mark.rutland, tglx, galak, santosh.shilimkar, bcousson,
robherring2
Tony,
On 05/07/2014 09:56 AM, Darren Etheridge wrote:
> Sricharan R <r.sricharan@ti.com> wrote on Wed [2014-May-07 17:46:36 +0530]:
>> Some socs have a large number of interrupts requests to service
>> the needs of its many peripherals and subsystems. All of the interrupt
>> requests lines from the subsystems are not needed at the same
>> time, so they have to be muxed to the controllers appropriately.
>> In such places a interrupt controllers are preceded by an
>> IRQ CROSSBAR that provides flexibility in muxing the device interrupt
>> requests to the controller inputs.
>>
>> The dts file update to support the crossbar device and convert
>> peripheral irq numbers to crossbar number are added here.
>>
>> This is a rebase on top of 3.15-rc4
>>
>> This series depends on crossbar-driver-fixes sent below
>> http://marc.info/?l=linux-omap&m=139929963420299&w=2
>>
>> [V6] Reordered patch 3 to patch 1 and
>> squashed patch 2 and 3 from V5 in to patch 2
>>
>> Sricharan R (2):
>> arm: dts: dra7: Add routable-irqs property for gic node
>> arm: dts: dra7: Add crossbar device binding
>>
>
> Just for thoroughness I dropped the previous 3 patch series from my
> build and replaced with this two patch series. Everything still works
> with my test setup so I consider these patches good.
>
It looks like in further tests, there may be more interrupts like irq
10 which are not documented properly and if mapped results in the
feature not working. It does seem that we might need more detailed
validation as this seems to have skipped our "non-OS validation" flow
unfortunately. we are in discussion with silicon folks on these
"undocumented behavior" we are discovering :(.
I suggest holding the series till we have done complete validation of
the same and explanation for the behavior we see.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH V6 0/2] arm: dts: dra7: Updates for adding crossbar device
@ 2014-05-07 15:29 ` Nishanth Menon
0 siblings, 0 replies; 12+ messages in thread
From: Nishanth Menon @ 2014-05-07 15:29 UTC (permalink / raw)
To: Darren Etheridge, Sricharan R
Cc: linux-kernel, devicetree, linux-doc, linux-arm-kernel, linux-omap,
linus.walleij, linux, tony, rnayak, marc.zyngier, grant.likely,
mark.rutland, tglx, galak, santosh.shilimkar, bcousson,
robherring2
Tony,
On 05/07/2014 09:56 AM, Darren Etheridge wrote:
> Sricharan R <r.sricharan@ti.com> wrote on Wed [2014-May-07 17:46:36 +0530]:
>> Some socs have a large number of interrupts requests to service
>> the needs of its many peripherals and subsystems. All of the interrupt
>> requests lines from the subsystems are not needed at the same
>> time, so they have to be muxed to the controllers appropriately.
>> In such places a interrupt controllers are preceded by an
>> IRQ CROSSBAR that provides flexibility in muxing the device interrupt
>> requests to the controller inputs.
>>
>> The dts file update to support the crossbar device and convert
>> peripheral irq numbers to crossbar number are added here.
>>
>> This is a rebase on top of 3.15-rc4
>>
>> This series depends on crossbar-driver-fixes sent below
>> http://marc.info/?l=linux-omap&m=139929963420299&w=2
>>
>> [V6] Reordered patch 3 to patch 1 and
>> squashed patch 2 and 3 from V5 in to patch 2
>>
>> Sricharan R (2):
>> arm: dts: dra7: Add routable-irqs property for gic node
>> arm: dts: dra7: Add crossbar device binding
>>
>
> Just for thoroughness I dropped the previous 3 patch series from my
> build and replaced with this two patch series. Everything still works
> with my test setup so I consider these patches good.
>
It looks like in further tests, there may be more interrupts like irq
10 which are not documented properly and if mapped results in the
feature not working. It does seem that we might need more detailed
validation as this seems to have skipped our "non-OS validation" flow
unfortunately. we are in discussion with silicon folks on these
"undocumented behavior" we are discovering :(.
I suggest holding the series till we have done complete validation of
the same and explanation for the behavior we see.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH V6 0/2] arm: dts: dra7: Updates for adding crossbar device
@ 2014-05-07 15:29 ` Nishanth Menon
0 siblings, 0 replies; 12+ messages in thread
From: Nishanth Menon @ 2014-05-07 15:29 UTC (permalink / raw)
To: linux-arm-kernel
Tony,
On 05/07/2014 09:56 AM, Darren Etheridge wrote:
> Sricharan R <r.sricharan@ti.com> wrote on Wed [2014-May-07 17:46:36 +0530]:
>> Some socs have a large number of interrupts requests to service
>> the needs of its many peripherals and subsystems. All of the interrupt
>> requests lines from the subsystems are not needed at the same
>> time, so they have to be muxed to the controllers appropriately.
>> In such places a interrupt controllers are preceded by an
>> IRQ CROSSBAR that provides flexibility in muxing the device interrupt
>> requests to the controller inputs.
>>
>> The dts file update to support the crossbar device and convert
>> peripheral irq numbers to crossbar number are added here.
>>
>> This is a rebase on top of 3.15-rc4
>>
>> This series depends on crossbar-driver-fixes sent below
>> http://marc.info/?l=linux-omap&m=139929963420299&w=2
>>
>> [V6] Reordered patch 3 to patch 1 and
>> squashed patch 2 and 3 from V5 in to patch 2
>>
>> Sricharan R (2):
>> arm: dts: dra7: Add routable-irqs property for gic node
>> arm: dts: dra7: Add crossbar device binding
>>
>
> Just for thoroughness I dropped the previous 3 patch series from my
> build and replaced with this two patch series. Everything still works
> with my test setup so I consider these patches good.
>
It looks like in further tests, there may be more interrupts like irq
10 which are not documented properly and if mapped results in the
feature not working. It does seem that we might need more detailed
validation as this seems to have skipped our "non-OS validation" flow
unfortunately. we are in discussion with silicon folks on these
"undocumented behavior" we are discovering :(.
I suggest holding the series till we have done complete validation of
the same and explanation for the behavior we see.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 12+ messages in thread