From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi9D0-0003ge-TA for qemu-devel@nongnu.org; Wed, 07 May 2014 17:17:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wi9Cw-0006yv-Gt for qemu-devel@nongnu.org; Wed, 07 May 2014 17:16:58 -0400 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:46921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi9Cw-0006yh-AG for qemu-devel@nongnu.org; Wed, 07 May 2014 17:16:54 -0400 Received: by mail-wg0-f50.google.com with SMTP id x12so1626617wgg.9 for ; Wed, 07 May 2014 14:16:53 -0700 (PDT) Date: Wed, 7 May 2014 22:16:40 +0100 From: Hani Benhabiles Message-ID: <20140507211640.GA22402@Inspiron-3521> References: <1399400197-7180-1-git-send-email-ncmike@ncultra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Mike Day , Blue Swirl , QEMU Developers On Tue, May 06, 2014 at 07:28:35PM +0100, Peter Maydell wrote: > On 6 May 2014 19:16, Mike Day wrote: > > This updates scripts/checkpatch.pl to version 0.32. Also, > > forward-ported the QEMU checks for no tabs and correct capitalization > > of "QEMU." Finally, make --no-tree the default option since this will > > be used with Qemu. > > > > Signed-off-by: Mike Day > > --- > > > > Notes: This is a huge patch and I needed to include white space > > changes to get it applying cleanly. > > I've tested this so far with some random patches off the mailing list > > and some others that I've got around. I also tested for some intentional > > errors. > > > > scripts/checkpatch.pl | 2544 ++++++++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 2120 insertions(+), 424 deletions(-) > > I think this is going to be difficult to review, to say the least. > > Where does your patch come from? Is the kernel's checkpatch.pl > just a single commit between 0.31 and 0.32 (surely not) or > a series of fixes? > > A couple of ideas about how we could approach this: > (1) make a commit which is simply copying the kernel's 0.32 > into our repo; then follow that with a series of commits which > re-apply our local changes. > (2) apply all the individual commits from the kernel between 0.31 > and 0.32 to our repo > (3) give up and stick with 0.31... > > (note that 1 and 2 here both end up with the same result as > applying this patch, but with a different commit history to get > there.) > > We only have 16 commits which touch checkpatch.pl, so > my favourite of these is (1). This also makes it easier when > we want to upgrade to 0.33 some time in the future, I think. > > It might also be helpful if you could describe the benefits > we get from this update (any bugfixes for false positives we > tend to run into? useful new checks?) FWIW, this new version doesn't trigger a false positive I was having with patches 05-07 in [1]. However, from a quick test for this patch on a couple of patches, I am getting warnings like this: "WARNING: braces {} are not necessary for single statement blocks" so there are still some Qemu related changes missing. [1] https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04180.html