From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 09/26] ARM: OMAP: dmtimer: Get rid of check for mem resource error Date: Wed, 7 May 2014 15:10:00 -0700 Message-ID: <20140507220959.GE19102@atomide.com> References: <1398375849-6017-1-git-send-email-joelf@ti.com> <1398375849-6017-10-git-send-email-joelf@ti.com> <20140507152426.GD9502@atomide.com> <536AAB1C.6010301@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <536AAB1C.6010301@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Joel Fernandes Cc: Linux OMAP List , Linux ARM Kernel List , Linux Kernel Mailing List List-Id: linux-omap@vger.kernel.org * Joel Fernandes [140507 14:53]: > On 05/07/2014 10:24 AM, Tony Lindgren wrote: > > * Joel Fernandes [140424 14:44]: > >> The subsequent devm_ioremap_resource will catch it and print an error, let it > >> be checked there. > >> > >> Signed-off-by: Joel Fernandes > >> --- > >> arch/arm/plat-omap/dmtimer.c | 4 ---- > >> 1 file changed, 4 deletions(-) > >> > >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c > >> index 7e806f9..1fd30fa 100644 > >> --- a/arch/arm/plat-omap/dmtimer.c > >> +++ b/arch/arm/plat-omap/dmtimer.c > >> @@ -810,10 +810,6 @@ static int omap_dm_timer_probe(struct platform_device *pdev) > >> } > >> > >> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> - if (unlikely(!mem)) { > >> - dev_err(dev, "%s: no memory resource.\n", __func__); > >> - return -ENODEV; > >> - } > >> > >> timer = devm_kzalloc(dev, sizeof(struct omap_dm_timer), GFP_KERNEL); > >> if (!timer) { > > > > We still need to return an error here and not try to continue though. > > We are returning an error if mem is NULL so the redundant check is > unnecessary: > > ... > timer->io_base = devm_ioremap_resource(dev, mem); > if (IS_ERR(timer->io_base)) > return PTR_ERR(timer->io_base); Why would you want to even continue omap_dm_timer_probe() further and allocate memory if platform_get_resource() fails? Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 7 May 2014 15:10:00 -0700 Subject: [PATCH 09/26] ARM: OMAP: dmtimer: Get rid of check for mem resource error In-Reply-To: <536AAB1C.6010301@ti.com> References: <1398375849-6017-1-git-send-email-joelf@ti.com> <1398375849-6017-10-git-send-email-joelf@ti.com> <20140507152426.GD9502@atomide.com> <536AAB1C.6010301@ti.com> Message-ID: <20140507220959.GE19102@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Joel Fernandes [140507 14:53]: > On 05/07/2014 10:24 AM, Tony Lindgren wrote: > > * Joel Fernandes [140424 14:44]: > >> The subsequent devm_ioremap_resource will catch it and print an error, let it > >> be checked there. > >> > >> Signed-off-by: Joel Fernandes > >> --- > >> arch/arm/plat-omap/dmtimer.c | 4 ---- > >> 1 file changed, 4 deletions(-) > >> > >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c > >> index 7e806f9..1fd30fa 100644 > >> --- a/arch/arm/plat-omap/dmtimer.c > >> +++ b/arch/arm/plat-omap/dmtimer.c > >> @@ -810,10 +810,6 @@ static int omap_dm_timer_probe(struct platform_device *pdev) > >> } > >> > >> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> - if (unlikely(!mem)) { > >> - dev_err(dev, "%s: no memory resource.\n", __func__); > >> - return -ENODEV; > >> - } > >> > >> timer = devm_kzalloc(dev, sizeof(struct omap_dm_timer), GFP_KERNEL); > >> if (!timer) { > > > > We still need to return an error here and not try to continue though. > > We are returning an error if mem is NULL so the redundant check is > unnecessary: > > ... > timer->io_base = devm_ioremap_resource(dev, mem); > if (IS_ERR(timer->io_base)) > return PTR_ERR(timer->io_base); Why would you want to even continue omap_dm_timer_probe() further and allocate memory if platform_get_resource() fails? Tony