All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Brunner <mibru@gmx.de>
To: gundberg <per.gundberg@icomera.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog
Date: Wed, 7 May 2014 22:19:41 +0200	[thread overview]
Message-ID: <20140507221941.2d6468ae@mail.gmx.de> (raw)
In-Reply-To: <5359165F.5040102@icomera.com>

On Thu, 24 Apr 2014 08:15:40 -0700, Guenter Roeck <linux@roeck-us.net>
wrote:
> On Thu, Apr 24, 2014 at 03:49:19PM +0200, gundberg wrote:
> > Use the prescaler index, rather than its value, to configure the
> > watchdog. This will prevent a mismatch with the prescaler used to
> > calculate the cycles.
> > 
> > Signed-off-by: Per Gundberg <per.gundberg@icomera.com>
> 
> Good catch. Looks correct to me. Michael, any comments ?
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Setting the prescaler incorrectly this way can cause the system to
reboot nearly immediately when activating the watchdog - not good.
This should also be applied to the stable revisions as this code is
included since 3.11.

Reviewed-by: Michael Brunner <michael.brunner@kontron.com>
Tested-by: Michael Brunner <michael.brunner@kontron.com>

Thanks,
Michael

  parent reply	other threads:[~2014-05-07 20:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 13:49 [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog gundberg
2014-04-24 15:15 ` Guenter Roeck
2014-05-07 20:19 ` Michael Brunner [this message]
     [not found] <CAKUdnSzO2ixCOvvxAwz3duXsPEpExVND7VA_DVPAYpwQGTwYdQ@mail.gmail.com>
2014-05-26 18:59 ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507221941.2d6468ae@mail.gmx.de \
    --to=mibru@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=per.gundberg@icomera.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.