From: Christoph Hellwig <hch@lst.de>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: clean up fh_auth usage
Date: Thu, 8 May 2014 08:27:23 +0200 [thread overview]
Message-ID: <20140508062723.GA9437@lst.de> (raw)
In-Reply-To: <20140507160118.GD4240@fieldses.org>
On Wed, May 07, 2014 at 12:01:18PM -0400, J. Bruce Fields wrote:
> On Wed, May 07, 2014 at 01:49:44PM +0200, Christoph Hellwig wrote:
> > Use fh_fsid when reffering to the fsid part of the filehandle. The
> > variable length auth field envisioned in nfsfh wasn't ever implemented.
> > Also clean up some lose ends around this and document the file handle
> > format better.
>
> Thanks.
>
> > Btw, why do we even export nfsfh.h to userspace? The file handle very
> > much is kernel private, and nothing in nfs-utils include the header
> > either.
>
> Something like wireshark might use that information? But anyway that
> doesn't mean it makes much sense to export. I'm fine with moving that
> header.
Let's just put this version in for now, I'll do some research if the
uapi <linux/nfsd/*.h> headers are used anywhere at all, if not I'll
send a series to kill them all.
next prev parent reply other threads:[~2014-05-08 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 11:49 [PATCH] nfsd: clean up fh_auth usage Christoph Hellwig
2014-05-07 16:01 ` J. Bruce Fields
2014-05-08 6:27 ` Christoph Hellwig [this message]
2014-05-08 15:28 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508062723.GA9437@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.