From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mmc: rtsx: usb backend needs LED support Date: Thu, 8 May 2014 09:29:11 +0100 Message-ID: <20140508082911.GA5767@lee--X1> References: <7208467.nZIXMIfPji@wuerfel> <201404300228.s3U2S7WA026782@rtits1.realtek.com> <53606F49.1000401@realtek.com> <536B3B6F.1010209@realtek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <536B3B6F.1010209@realtek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Roger Cc: Ulf Hansson , Samuel Ortiz , Arnd Bergmann , Greg Kroah-Hartman , linux-mmc , Chris Ball , "linux-kernel@vger.kernel.org" , Wei WANG , devel@linuxdriverproject.org, Dan Carpenter List-Id: linux-mmc@vger.kernel.org PiA+PkZyb206IFJvZ2VyIFRzZW5nIDxyb2dlcmFibGVAcmVhbHRlay5jb20+Cj4gPj5EYXRlOiBX ZWQsIDMwIEFwciAyMDE0IDExOjExOjI1ICswODAwCj4gPj5TdWJqZWN0OiBbUEFUQ0hdIG1tYzog cnRzeDogZml4IHBvc3NpYmxlIGxpbmtpbmcgZXJyb3IgaWYgYnVpbHQtaW4KPiA+Pgo+ID4+cnRz eF91c2Jfc2RtbWMgbW9kdWxlIHVzZXMgdGhlIExFRCBjbGFzc2RldiBpZiBhdmFpbGFibGUsIGJ1 dCB0aGUgY29kZQo+ID4+ZmFpbGVkCj4gPj50byBjb25zaWRlciB0aGUgc2l0dWF0aW9uIHRoYXQg aXQgaXMgYnVpbHQtaW4gYW5kIHRoZSBMRUQgY2xhc3NkZXYgaXMgYQo+ID4+bW9kdWxlLAo+ID4+ bGVhZGluZyB0byBmb2xsb3dpbmcgbGlua2luZyBlcnJvcjoKPiA+Pgo+ID4+ICAgTEQgICAgICBp bml0L2J1aWx0LWluLm8KPiA+PmRyaXZlcnMvYnVpbHQtaW4ubzogSW4gZnVuY3Rpb24gYHJ0c3hf dXNiX3NkbW1jX2Rydl9yZW1vdmUnOgo+ID4+cnRzeF91c2Jfc2RtbWMuYzooLnRleHQrMHgyYTAx OGUpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvCj4gPj5gbGVkX2NsYXNzZGV2X3VucmVnaXN0ZXIn Cj4gPj5kcml2ZXJzL2J1aWx0LWluLm86IEluIGZ1bmN0aW9uIGBydHN4X3VzYl9zZG1tY19kcnZf cHJvYmUnOgo+ID4+cnRzeF91c2Jfc2RtbWMuYzooLnRleHQrMHgyYTE5N2UpOiB1bmRlZmluZWQg cmVmZXJlbmNlIHRvCj4gPj5gbGVkX2NsYXNzZGV2X3JlZ2lzdGVyJwo+ID4+Cj4gPj5GaXggYnkg ZXhjbHVkaW5nIHN1Y2ggY29uZGl0aW9uIHdoZW4gZGVmaW5pbmcgbWFjcm8gUlRTWF9VU0JfVVNF X0xFRFNfQ0xBU1MuCj4gPj4KPiA+PlNpZ25lZC1vZmYtYnk6IFJvZ2VyIFRzZW5nIDxyb2dlcmFi bGVAcmVhbHRlay5jb20+Cj4gPgo+ID5BY2tlZC1ieTogVWxmIEhhbnNzb24gPHVsZi5oYW5zc29u QGxpbmFyby5vcmc+Cj4gCj4gV291bGQgdGhpcyBwYXRjaCBiZSBtZXJnZWQgaW50byBsaW51eC1u ZXh0IG9yIExlZSdzIG1mZC5naXQKPiBpYi1tZmQtbW1jLW1lbXN0aWNrLTMuMTYgYnJhbmNoPwoK VGhpcyBwYXRjaCBkb2Vzbid0IGhhdmUgYW55dGhpbmcgdG8gZG8gd2l0aCBNRkQuCgotLSAKTGVl IEpvbmVzCkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFtIExlYWQKTGluYXJv Lm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86 IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4ZHJpdmVycHJv amVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRyaXZlcnByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753369AbaEHI3X (ORCPT ); Thu, 8 May 2014 04:29:23 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:64388 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753141AbaEHI3U (ORCPT ); Thu, 8 May 2014 04:29:20 -0400 Date: Thu, 8 May 2014 09:29:11 +0100 From: Lee Jones To: Roger Cc: Ulf Hansson , Arnd Bergmann , micky , Chris Ball , Samuel Ortiz , Greg Kroah-Hartman , Dan Carpenter , devel@linuxdriverproject.org, "linux-kernel@vger.kernel.org" , linux-mmc , Wei WANG Subject: Re: [PATCH] mmc: rtsx: usb backend needs LED support Message-ID: <20140508082911.GA5767@lee--X1> References: <7208467.nZIXMIfPji@wuerfel> <201404300228.s3U2S7WA026782@rtits1.realtek.com> <53606F49.1000401@realtek.com> <536B3B6F.1010209@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <536B3B6F.1010209@realtek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >>From: Roger Tseng > >>Date: Wed, 30 Apr 2014 11:11:25 +0800 > >>Subject: [PATCH] mmc: rtsx: fix possible linking error if built-in > >> > >>rtsx_usb_sdmmc module uses the LED classdev if available, but the code > >>failed > >>to consider the situation that it is built-in and the LED classdev is a > >>module, > >>leading to following linking error: > >> > >> LD init/built-in.o > >>drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove': > >>rtsx_usb_sdmmc.c:(.text+0x2a018e): undefined reference to > >>`led_classdev_unregister' > >>drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_probe': > >>rtsx_usb_sdmmc.c:(.text+0x2a197e): undefined reference to > >>`led_classdev_register' > >> > >>Fix by excluding such condition when defining macro RTSX_USB_USE_LEDS_CLASS. > >> > >>Signed-off-by: Roger Tseng > > > >Acked-by: Ulf Hansson > > Would this patch be merged into linux-next or Lee's mfd.git > ib-mfd-mmc-memstick-3.16 branch? This patch doesn't have anything to do with MFD. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog