All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: "Petter Mabäcker" <petter@technux.se>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 04/13] trace-cmd: remove usage of FILESPATH
Date: Thu, 8 May 2014 12:46:06 +0200	[thread overview]
Message-ID: <20140508104606.GM30955@jama> (raw)
In-Reply-To: <699098e9da6b5932cce137031ad8dc3604d949a3.1399497346.git.petter@technux.se>

[-- Attachment #1: Type: text/plain, Size: 6050 bytes --]

On Wed, May 07, 2014 at 11:19:50PM +0200, Petter Mabäcker wrote:
> Fixes [YOCTO #4497]
> 
> Usage of FILESPATH is discouraged, since it can make recipes harder to
> bbappend. All current patches in trace-cmd are shared, move them to
> files instead, since it's included in base FILESPATH.

FWIW: using "files" is also a bit discouraged, because it's searched
last, so the lookup takes longer (trying ~30 different directories a lot
more with more OVERRIDES).

I don't know what's worse.

> Signed-off-by: Petter Mabäcker <petter@technux.se>
> ---
>  .../{trace-cmd => files}/addldflags.patch          |    0
>  .../blktrace-api-compatibility.patch               |    0
>  .../kernelshark-fix-syntax-error-of-shell.patch    |    0
>  .../{trace-cmd => files}/make-docs-optional.patch  |    0
>  ...dd-checks-for-invalid-pointers-to-fix-seg.patch |    0
>  ...o-not-call-stop_threads-if-doing-latency-.patch |    0
>  ...etting-plugin-to-nop-clears-data-before-i.patch |    0
>  .../trace-cmd-fix-syntax-error-of-shell.patch      |    0
>  meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |    2 --
>  9 files changed, 2 deletions(-)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/addldflags.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/blktrace-api-compatibility.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/kernelshark-fix-syntax-error-of-shell.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/make-docs-optional.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/trace-cmd-fix-syntax-error-of-shell.patch (100%)
> 
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/addldflags.patch b/meta/recipes-kernel/trace-cmd/files/addldflags.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/addldflags.patch
> rename to meta/recipes-kernel/trace-cmd/files/addldflags.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/blktrace-api-compatibility.patch b/meta/recipes-kernel/trace-cmd/files/blktrace-api-compatibility.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/blktrace-api-compatibility.patch
> rename to meta/recipes-kernel/trace-cmd/files/blktrace-api-compatibility.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/files/kernelshark-fix-syntax-error-of-shell.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> rename to meta/recipes-kernel/trace-cmd/files/kernelshark-fix-syntax-error-of-shell.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/make-docs-optional.patch b/meta/recipes-kernel/trace-cmd/files/make-docs-optional.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/make-docs-optional.patch
> rename to meta/recipes-kernel/trace-cmd/files/make-docs-optional.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch b/meta/recipes-kernel/trace-cmd/files/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch
> rename to meta/recipes-kernel/trace-cmd/files/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch b/meta/recipes-kernel/trace-cmd/files/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch
> rename to meta/recipes-kernel/trace-cmd/files/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch b/meta/recipes-kernel/trace-cmd/files/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch
> rename to meta/recipes-kernel/trace-cmd/files/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/files/trace-cmd-fix-syntax-error-of-shell.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
> rename to meta/recipes-kernel/trace-cmd/files/trace-cmd-fix-syntax-error-of-shell.patch
> diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> index d61097d..291c068 100644
> --- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> @@ -21,8 +21,6 @@ S = "${WORKDIR}/git"
>  
>  EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
>  
> -FILESPATH = "${FILE_DIRNAME}/trace-cmd"
> -
>  do_install() {
>  	oe_runmake CC="${CC}" AR="${AR}" prefix="${prefix}" DESTDIR="${D}" install_gui
>  	rm -rf ${D}${datadir}/trace-cmd
> -- 
> 1.7.9.5
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2014-05-08 10:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07 21:19 [PATCH 00/13] Remove usage of FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 01/13] systemtap: remove " Petter Mabäcker
2014-05-07 21:19 ` [PATCH 02/13] dbus: " Petter Mabäcker
2014-05-07 21:19 ` [PATCH 03/13] gstreamer: remove unused FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 04/13] trace-cmd: remove usage of FILESPATH Petter Mabäcker
2014-05-08 10:46   ` Martin Jansa [this message]
2014-05-08 14:56     ` petter
2014-05-07 21:19 ` [PATCH 05/13] xorg-lib: " Petter Mabäcker
2014-05-07 21:19 ` [PATCH 06/13] mesa: " Petter Mabäcker
2014-05-08 10:49   ` Martin Jansa
2014-05-09  5:11     ` petter
2014-05-07 21:19 ` [PATCH 07/13] qemu: remove unused FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 08/13] linuxdoc-tools: remove usage of FILESPATH Petter Mabäcker
2014-05-08 10:50   ` Martin Jansa
2014-05-08 14:48     ` petter
2014-05-07 21:19 ` [PATCH 09/13] gcc: " Petter Mabäcker
2014-05-07 21:19 ` [PATCH 10/13] python: " Petter Mabäcker
2014-05-08 10:53   ` Martin Jansa
2014-05-09  4:53     ` petter
2014-05-07 21:19 ` [PATCH 11/13] u-boot: remove unused FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 12/13] uclibc: remove usage of FILESPATH Petter Mabäcker
2014-05-07 21:19 ` [PATCH 13/13] eglibc: " Petter Mabäcker
2014-05-07 22:21 ` [PATCH 00/13] Remove " Richard Purdie
2014-05-08  4:37   ` petter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140508104606.GM30955@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=petter@technux.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.