All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] musb-new, dfu: first send request answer then call completions
Date: Thu, 08 May 2014 10:47:22 +0200	[thread overview]
Message-ID: <20140508104722.369b7426@amdc2363> (raw)
In-Reply-To: <1397106486-1233-1-git-send-email-hs@denx.de>

Hi Heiko,

> comment in ep0_txstate() states:
> 
> "report completions as soon as the fifo's loaded; there's no win
>  in waiting till this last packet gets acked".
> 
> This is wrong for using dfu. In the dfu usecase we must send
> a PollTimeout to the host, so the host can wait until the
> U-Boot Code is ready for answering new usb requests. So the
> answer which contains the PollTimeout must send *before*
> U-Boot calls req->complete.
> 
> The req->complete is used in the dfu case for flushing the
> medium, when entering DFU_STATE_dfuMANIFEST_SYNC state.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>

Applied to u-boot-dfu. Thanks.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

      parent reply	other threads:[~2014-05-08  8:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10  5:08 [U-Boot] [PATCH 1/2] musb-new, dfu: first send request answer then call completions Heiko Schocher
2014-04-10  5:08 ` [U-Boot] [PATCH 2/2] dfu, nand: add medium specific polltimeout function Heiko Schocher
2014-04-10  7:54   ` Marek Vasut
2014-04-10  8:29     ` Pantelis Antoniou
2014-04-10 10:08       ` Lukasz Majewski
2014-04-10 10:21         ` Heiko Schocher
2014-04-10 14:31           ` Lukasz Majewski
2014-04-11  4:22             ` Heiko Schocher
2014-04-11  7:20               ` Lukasz Majewski
2014-04-10 11:10         ` Marek Vasut
2014-04-10  7:50 ` [U-Boot] [PATCH 1/2] musb-new, dfu: first send request answer then call completions Marek Vasut
2014-05-08  8:47 ` Lukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140508104722.369b7426@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.