From: "J. Bruce Fields" <bfields@fieldses.org>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: Get rid of empty function nfs4_state_init
Date: Thu, 8 May 2014 13:06:06 -0400 [thread overview]
Message-ID: <20140508170606.GH20976@fieldses.org> (raw)
In-Reply-To: <534383D4.50504@gmail.com>
Thanks, applying.--b.
On Tue, Apr 08, 2014 at 01:06:28PM +0800, Kinglong Mee wrote:
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
> fs/nfsd/nfs4state.c | 7 -------
> fs/nfsd/nfsctl.c | 1 -
> fs/nfsd/nfsd.h | 2 --
> 3 files changed, 10 deletions(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 5a9588e..6e786a8 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -4969,13 +4969,6 @@ struct nfs4_client *nfsd_find_client(struct
> sockaddr_storage *addr, size_t addr_
>
> #endif /* CONFIG_NFSD_FAULT_INJECTION */
>
> -/* initialization to perform at module load time: */
> -
> -void
> -nfs4_state_init(void)
> -{
> -}
> -
> /*
> * Since the lifetime of a delegation isn't limited to that of an open, a
> * client may quite reasonably hang on to a delegation as long as it has
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 7f55517..493f3d4 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1174,7 +1174,6 @@ static int __init init_nfsd(void)
> retval = nfsd4_init_slabs();
> if (retval)
> goto out_unregister_pernet;
> - nfs4_state_init();
> retval = nfsd_fault_inject_init(); /* nfsd fault injection controls */
> if (retval)
> goto out_free_slabs;
> diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
> index 30f34ab..22259f8 100644
> --- a/fs/nfsd/nfsd.h
> +++ b/fs/nfsd/nfsd.h
> @@ -106,7 +106,6 @@ static inline int nfsd_v4client(struct svc_rqst *rq)
> */
> #ifdef CONFIG_NFSD_V4
> extern unsigned long max_delegations;
> -void nfs4_state_init(void);
> int nfsd4_init_slabs(void);
> void nfsd4_free_slabs(void);
> int nfs4_state_start(void);
> @@ -117,7 +116,6 @@ void nfs4_reset_lease(time_t leasetime);
> int nfs4_reset_recoverydir(char *recdir);
> char * nfs4_recoverydir(void);
> #else
> -static inline void nfs4_state_init(void) { }
> static inline int nfsd4_init_slabs(void) { return 0; }
> static inline void nfsd4_free_slabs(void) { }
> static inline int nfs4_state_start(void) { return 0; }
> --
> 1.9.0
>
prev parent reply other threads:[~2014-05-08 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 5:06 [PATCH] NFSD: Get rid of empty function nfs4_state_init Kinglong Mee
2014-05-08 17:06 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508170606.GH20976@fieldses.org \
--to=bfields@fieldses.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.