From: Dave Chinner <david@fromorbit.com>
To: Emmanuel Florac <eflorac@intellique.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Remove xfs_check for 3.2.0?
Date: Fri, 9 May 2014 08:02:14 +1000 [thread overview]
Message-ID: <20140508220214.GF26353@dastard> (raw)
In-Reply-To: <20140508230410.02b19431@galadriel.home>
On Thu, May 08, 2014 at 11:04:10PM +0200, Emmanuel Florac wrote:
> Le Thu, 08 May 2014 15:40:57 -0500 vous écriviez:
>
> > *shrug* ok. Let a thousand "hey my xfs_check OOM'd" emails
> > blossom! :)
> >
> > FWIW, I did not have time to work on that prefetch bug yet today. :(
> >
>
> Why not replace it by a script that simply states that it's useless and
> to run xfs_repair -n instead? It has been completely useless for the
> best part of the past ten years... This way you don't remove it but
> you'll sort of fix it :)
xfs_check is already just a script that wraps xfs_db.
However, there's all the man page updates, all the external
documentation needs to be updated, etc. IOWs, it's not just a case
of a simply patching out the xfs_check script....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-05-08 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 18:40 Remove xfs_check for 3.2.0? Eric Sandeen
2014-05-08 20:39 ` Dave Chinner
2014-05-08 20:40 ` Eric Sandeen
2014-05-08 21:04 ` Emmanuel Florac
2014-05-08 22:02 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508220214.GF26353@dastard \
--to=david@fromorbit.com \
--cc=eflorac@intellique.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.