From: Zhuang Jin Can <jin.can.zhuang@intel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Felipe Balbi <balbi@ti.com>, USB list <linux-usb@vger.kernel.org>,
linux-omap@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>,
liping.zhou@intel.com, david.a.cohen@linux.intel.com
Subject: Re: [PATCH] usb: dwc3: ep0: fix delayed status is queued too early
Date: Thu, 8 May 2014 23:01:33 -0400 [thread overview]
Message-ID: <20140509030133.GK19925@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1405081019230.1087-100000@iolanthe.rowland.org>
On Thu, May 08, 2014 at 10:25:46AM -0400, Alan Stern wrote:
> On Thu, 8 May 2014, Zhuang Jin Can wrote:
>
> > > When the host already timed out the control transfer and started a new
> > > one. Here's what I'm talking about:
> > >
> > > Host sends a Set-Configuration request.
> > >
> > > The UDC driver calls the gadget driver's setup function.
> > >
> > > The setup function returns DELAYED_STATUS.
> > >
> > > After a few seconds, the host gets tired of waiting and
> > > sends a Get-Descriptor request
> > My understanding is dwc3 will return NYET to host for this
> > Get-Descriptor request transaction, as dwc3 is still in STATUS phase,
> > there's no buffer to receive anything in ep0-out.
>
> dwc3 _cannot_ return NYET to a SETUP packet. The USB protocol does not
> allow it. A device must always respond to SETUP with ACK.
It true that device can not return NYET to a SETUP packet.
A device must always respond to SETUP with ACK _if_ the SETUP packet is
correctly received. Because there's no buffer prepared in ep0 for dwc3
to receive the SETUP packet, I guess there will be no handshake
returned to host. I can confirm this by doing an experiment tomorrow:)
Jincan
next prev parent reply other threads:[~2014-05-09 3:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 21:53 [PATCH] usb: dwc3: ep0: fix delayed status is queued too early Zhuang Jin Can
2014-05-07 15:03 ` Alan Stern
2014-05-07 15:03 ` Alan Stern
2014-05-08 4:39 ` Zhuang Jin Can
2014-05-07 16:59 ` Alan Stern
2014-05-07 16:59 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1405071252550.1325-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-05-08 16:00 ` Zhuang Jin Can
2014-05-08 16:00 ` Zhuang Jin Can
2014-05-08 14:25 ` Alan Stern
2014-05-08 14:25 ` Alan Stern
2014-05-09 3:01 ` Zhuang Jin Can [this message]
2014-05-08 15:22 ` Alan Stern
2014-05-08 15:22 ` Alan Stern
2014-05-09 5:03 ` Zhuang Jin Can
2014-05-08 19:55 ` Paul Zimmerman
2014-05-08 21:18 ` Alan Stern
2014-05-08 23:01 ` Paul Zimmerman
2014-05-09 14:08 ` Alan Stern
[not found] ` <20140507215344.GH19925-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-05-14 1:45 ` Zhuang Jin Can
2014-05-14 1:45 ` Zhuang Jin Can
2014-05-13 15:05 ` Felipe Balbi
2014-05-13 15:05 ` Felipe Balbi
2014-05-14 3:28 ` Zhuang Jin Can
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509030133.GK19925@intel.com \
--to=jin.can.zhuang@intel.com \
--cc=balbi@ti.com \
--cc=david.a.cohen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liping.zhou@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.