From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Fri, 9 May 2014 09:08:07 +0100 Subject: [PATCH v2 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit In-Reply-To: <536C84F6.2050701@redhat.com> References: <1399483554-8824-1-git-send-email-boris.brezillon@free-electrons.com> <1399483554-8824-4-git-send-email-boris.brezillon@free-electrons.com> <20140508110205.GB5767@lee--X1> <536BE366.8080907@free-electrons.com> <20140509071246.GE5767@lee--X1> <536C84F6.2050701@redhat.com> Message-ID: <20140509080807.GH5767@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > >>>> +static struct platform_driver sun6i_prcm_driver = { > >>>> + .driver = { > >>>> + .name = "sun6i-prcm", > >>>> + .owner = THIS_MODULE, > >>>> + .of_match_table = sun6i_prcm_dt_ids, > >>>> + }, > >>>> + .probe = sun6i_prcm_probe, > >>> You need a .remove() call-back. > >> > >> This driver cannot be compiled as module (see the Kconfig definition) > >> and the devices are not hotpluggable, as a result a probed device will > >> never be removed. > >> > >> Do you still want me to implement the remove function ? > > > > .remove() also be run on shut down. > > That is not true, if your device needs to do anything special at shutdown > you need to add a shutdown callback. Devices are kept as is (not torn down) > on shutdown. Ah okay, I'll bow to your knowledge. So there's no reason for this driver to ever call mfd_remove_devices() then? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit Date: Fri, 9 May 2014 09:08:07 +0100 Message-ID: <20140509080807.GH5767@lee--X1> References: <1399483554-8824-1-git-send-email-boris.brezillon@free-electrons.com> <1399483554-8824-4-git-send-email-boris.brezillon@free-electrons.com> <20140508110205.GB5767@lee--X1> <536BE366.8080907@free-electrons.com> <20140509071246.GE5767@lee--X1> <536C84F6.2050701@redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <536C84F6.2050701-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , Content-Disposition: inline To: Hans de Goede Cc: Boris BREZILLON , Emilio =?iso-8859-1?Q?L=F3pez?= , Mike Turquette , Samuel Ortiz , Chen-Yu Tsai , Maxime Ripard , Philipp Zabel , Shuge , kevin-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org, Randy Dunlap , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org List-Id: devicetree@vger.kernel.org > >>>> +static struct platform_driver sun6i_prcm_driver =3D { > >>>> + .driver =3D { > >>>> + .name =3D "sun6i-prcm", > >>>> + .owner =3D THIS_MODULE, > >>>> + .of_match_table =3D sun6i_prcm_dt_ids, > >>>> + }, > >>>> + .probe =3D sun6i_prcm_probe, > >>> You need a .remove() call-back. > >> > >> This driver cannot be compiled as module (see the Kconfig definition) > >> and the devices are not hotpluggable, as a result a probed device will > >> never be removed. > >> > >> Do you still want me to implement the remove function ? > >=20 > > .remove() also be run on shut down. >=20 > That is not true, if your device needs to do anything special at shutdown > you need to add a shutdown callback. Devices are kept as is (not torn dow= n) > on shutdown. Ah okay, I'll bow to your knowledge. So there's no reason for this driver to ever call mfd_remove_devices() then? --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756041AbaEIIIU (ORCPT ); Fri, 9 May 2014 04:08:20 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:55702 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbaEIIIO (ORCPT ); Fri, 9 May 2014 04:08:14 -0400 Date: Fri, 9 May 2014 09:08:07 +0100 From: Lee Jones To: Hans de Goede Cc: Boris BREZILLON , Emilio =?iso-8859-1?Q?L=F3pez?= , Mike Turquette , Samuel Ortiz , Chen-Yu Tsai , Maxime Ripard , Philipp Zabel , Shuge , kevin@allwinnertech.com, Randy Dunlap , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dev@linux-sunxi.org Subject: Re: [PATCH v2 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit Message-ID: <20140509080807.GH5767@lee--X1> References: <1399483554-8824-1-git-send-email-boris.brezillon@free-electrons.com> <1399483554-8824-4-git-send-email-boris.brezillon@free-electrons.com> <20140508110205.GB5767@lee--X1> <536BE366.8080907@free-electrons.com> <20140509071246.GE5767@lee--X1> <536C84F6.2050701@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <536C84F6.2050701@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >>>> +static struct platform_driver sun6i_prcm_driver = { > >>>> + .driver = { > >>>> + .name = "sun6i-prcm", > >>>> + .owner = THIS_MODULE, > >>>> + .of_match_table = sun6i_prcm_dt_ids, > >>>> + }, > >>>> + .probe = sun6i_prcm_probe, > >>> You need a .remove() call-back. > >> > >> This driver cannot be compiled as module (see the Kconfig definition) > >> and the devices are not hotpluggable, as a result a probed device will > >> never be removed. > >> > >> Do you still want me to implement the remove function ? > > > > .remove() also be run on shut down. > > That is not true, if your device needs to do anything special at shutdown > you need to add a shutdown callback. Devices are kept as is (not torn down) > on shutdown. Ah okay, I'll bow to your knowledge. So there's no reason for this driver to ever call mfd_remove_devices() then? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog