From: Dan Carpenter <dan.carpenter@oracle.com>
To: DaeSeok Youn <daeseok.youn@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel <devel@driverdev.osuosl.org>,
nandini h <nandu.hgowda@gmail.com>,
"sachin.kamat" <sachin.kamat@linaro.org>,
peter.p.waskiewicz.jr@intel.com,
linux-kernel <linux-kernel@vger.kernel.org>,
Himangi Saraogi <himangi774@gmail.com>,
Chekameh Cobbler <fempsci@gmail.com>
Subject: Re: [PATCH 1/3] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c
Date: Fri, 9 May 2014 11:28:03 +0300 [thread overview]
Message-ID: <20140509082803.GC4963@mwanda> (raw)
In-Reply-To: <CAHb8M2AOxLS_nA4BFy2q7+TyyLYxUTmzVULn8dvuR-X2fsET=w@mail.gmail.com>
On Fri, May 09, 2014 at 05:22:18PM +0900, DaeSeok Youn wrote:
> 2014-05-09 16:59 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
> > On Fri, May 09, 2014 at 10:38:43AM +0900, Daeseok Youn wrote:
> >> clean up checkpatch.pl warning:
> >> WARNING: please no spaces at the start of a line in
> >>
> >> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> >> ---
> >> This patch includes cleanup for fixing line length.
> >>
> >
> > This patch is super hard to review. Your "line length" fixes include
> > moving variable declarations around, deleting comments, getting rid of
> > nonsense curly braces. Those are all great but the patch is over a
> > thousand lines long and it's difficult to review.
> Yes.. I knew that. And sorry about that. but I was really hard to
> separate this patch for
> fixing coding style. :-(
> When I replaced spaces with tabs, it has too many tabs so I cannot leave
> that lines on this patch.(and removed curly braces can solve my concern..)
> But I should do as your comment.
Yeah. I know that it means we go over the 80 character limit. Don't
stress about that.
regards,
dan carpenter
prev parent reply other threads:[~2014-05-09 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 1:38 [PATCH 1/3] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c Daeseok Youn
2014-05-09 7:59 ` Dan Carpenter
2014-05-09 8:22 ` DaeSeok Youn
2014-05-09 8:28 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509082803.GC4963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fempsci@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nandu.hgowda@gmail.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.