All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available
Date: Fri, 9 May 2014 12:21:37 +0200	[thread overview]
Message-ID: <20140509102136.GD3173@free.fr> (raw)
In-Reply-To: <536CA383.404@trzebnica.net>

Jerzy, All,

[forgot to cc the Buildroot list on previous mail, sorry]

On 2014-05-09 11:44 +0200, Jerzy Grzegorek spake thusly:
> >From: Samuel Martin <s.martin49@gmail.com>
> >
> >zeromp's configure script correctly detects the fork availability, but
> >unconditionally build test_fork program whatever the fork() availability.
> >
> >This patch fixes the build-system by disabling test_fork when fork is
> >not available (e.g. when !BR2_USEMMU).
> >
> >Fixes:
> >   http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/
> >
> >Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> >[yann.morin.1998 at free.fr: remove Makefile.in hunks]
> >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >[yann.morin.1998 at free.fr: tested against the failed bfin config, as well as
> >  a i686 target]
> >Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >---
> >  ...isable-test_fork-if-fork-is-not-available.patch | 52 ++++++++++++++++++++++
> >  package/zeromq/zeromq.mk                           |  1 +
> >  2 files changed, 53 insertions(+)
> >  create mode 100644 package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
> >
> >diff --git a/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
> >new file mode 100644
> >index 0000000..1eefdc3
> >--- /dev/null
> >+++ b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
> >@@ -0,0 +1,52 @@
> >+From b50912f2eecec1ea7accc155f8132116f8702075 Mon Sep 17 00:00:00 2001
> >+From: Samuel Martin <s.martin49@gmail.com>
> >+Date: Sat, 3 May 2014 12:22:38 +0200
> >+Subject: [PATCH] tests: disable test_fork if fork() is not available
> >+
> >+Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> >+---
> >+ configure.ac      | 1 +
> >+ tests/Makefile.am | 8 ++++++--
> >+ tests/Makefile.in | 8 ++++----
> 
> What about the changes in Makefile.in file?
> I don't see them here.

Ah, right. When I edited the patch to remove them, I forgot to remove
Makefile.in from the diffstat. We do not need the changes to Makefile.in
in this patch, since we do autoreconf the beast, so Makefile.in gets
re-generated.

See the commit log that states;
    [yann.morin.1998 at free.fr: remove Makefile.in hunks]

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2014-05-09 10:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-03 16:33 [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available Yann E. MORIN
2014-05-03 19:03 ` Peter Korsgaard
2014-05-03 19:52   ` Samuel Martin
2014-05-09  9:47 ` Jerzy Grzegorek
     [not found] ` <536CA383.404@trzebnica.net>
2014-05-09 10:21   ` Yann E. MORIN [this message]
     [not found]   ` <20140509094736.GA3173@free.fr>
2014-05-09 10:42     ` Jerzy Grzegorek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140509102136.GD3173@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.