From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, himangi774@gmail.com,
sachin.kamat@linaro.org, fempsci@gmail.com,
nandu.hgowda@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] staging: cxt1e1: remove dead code in musycc.c
Date: Fri, 9 May 2014 13:51:49 +0300 [thread overview]
Message-ID: <20140509105149.GH4963@mwanda> (raw)
In-Reply-To: <20140509100606.GA6479@devel.8.8.4.4>
On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
> Removes "#if 0" blocks.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> Dan,
> I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
> out and make a block as "RLD_DEBUG". Because i think this block need to debug
> with define "RLD_DEBUG". If I am wrong, let me know.
>
This change should maybe have been in a separate patch. It's a border
line thing. But definitely, it should have been mentioned in the
changelog.
Btw, you can use `git citool` to add or remove lines from a
commit. Highlight and right click on the lines you want to add or
remove.
I don't really care either way if you keep it or delete it.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-09 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 10:06 [PATCH 2/5] staging: cxt1e1: remove dead code in musycc.c Daeseok Youn
2014-05-09 10:51 ` Dan Carpenter [this message]
2014-05-09 14:09 ` DaeSeok Youn
2014-05-09 14:15 ` Dan Carpenter
2014-05-09 14:25 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509105149.GH4963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fempsci@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nandu.hgowda@gmail.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.