From: Dan Carpenter <dan.carpenter@oracle.com>
To: sbehrens@giantdisaster.de
Cc: linux-btrfs@vger.kernel.org
Subject: re: Btrfs: add optional integrity check code
Date: Fri, 9 May 2014 15:00:07 +0300 [thread overview]
Message-ID: <20140509120007.GE32027@mwanda> (raw)
Hello Stefan Behrens,
The patch 5db0276014b8: "Btrfs: add optional integrity check code"
from Nov 1, 2011, leads to the following static checker warning:
fs/btrfs/check-integrity.c:1099 btrfsic_process_metablock()
warn: missing error code here? 'btrfsic_stack_frame_alloc()' failed. 'sf->error' = '0'
fs/btrfs/check-integrity.c
1092
1093 next_stack =
1094 btrfsic_stack_frame_alloc();
1095 if (NULL == next_stack) {
1096 btrfsic_release_block_ctx(
1097 &sf->
1098 next_block_ctx);
Should we set "sf->error" here? I don't know the code well enough to
say the answer.
1099 goto one_stack_frame_backwards;
1100 }
1101
1102 next_stack->i = -1;
regards,
dan carpenter
next reply other threads:[~2014-05-09 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 12:00 Dan Carpenter [this message]
2014-05-09 13:02 ` Btrfs: add optional integrity check code Stefan Behrens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509120007.GE32027@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.