Re: [Patch net] rtnetlink: call rtnl_lock_unregistering() in rtnl_link_unregister()

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 9 May 2014 11:10:36 -0700
Cong Wang <xiyou.wangcong@gmail.com> wrote:

> On Fri, May 9, 2014 at 11:03 AM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > On Fri,  9 May 2014 10:47:33 -0700
> > Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
> >> I know making rtnl_lock_unregistering() a macro is ugly, but I don't find
> >> any less ugly way to fix it unless we duplicate the code. For long term,
> >> I think we should clean up the mess of netdev_run_todo() and net namespce
> >> exit code.
> >
> > Huh, why isn't a real function going to work.
> 
> Because in its callers:
> 
> +       rtnl_lock_unregistering(net_list, exit_list);
> +       rtnl_lock_unregistering(&net_namespace_list, list);
> 
> struct net is linked via ->exit_list in net_list and is linked
> via ->list in net_namespace_list.
> 
> This can't be done without a macro (at least for me). Or
> we have to duplicate the code.

macro method is too ugly, figure out a better way.