All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ezequiel García" <ezequiel@vanguardiasur.com.ar>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: George Cherian <george.cherian@ti.com>,
	Yegor Yefremov <yegorslists@googlemail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early
Date: Fri, 9 May 2014 10:26:51 -0300	[thread overview]
Message-ID: <20140509132651.GD764@arch.cereza> (raw)
In-Reply-To: <536C82F1.6020809@linutronix.de>

On 09 May 09:25 AM, Sebastian Andrzej Siewior wrote:
> On 05/09/2014 08:22 AM, George Cherian wrote:
> > Just by remodelling the dt the whole problem can be solved.
> > I am still not convinced why we should not be doing it?
> > Because neither ways its not the exact representation of the H/W.
> 
> Ha. Now I am confused. First I assumed that the musb_am335x module is
> built-in only to duct-tape the bug you are seeing. So this patch never
> made it mainline then.

Mainline panics easily upon module removal: 

$ modprobe musb_am335x
$ modprobe musb_dsps

Here you insert something to the USB

$ modprobe musb_am335x -r ... bang! the kernel panics.

It works fine if you remove the musb_dsps and musb_am335x in that order,
but the dependency is not enforced anywhere.

So I guess preventing the module removal should be fine for now.
In that case, mind testing/acking/whatever this patch:

http://www.spinics.net/lists/linux-usb/msg107244.html

Regards,
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar

WARNING: multiple messages have this Message-ID (diff)
From: ezequiel@vanguardiasur.com.ar (Ezequiel García)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early
Date: Fri, 9 May 2014 10:26:51 -0300	[thread overview]
Message-ID: <20140509132651.GD764@arch.cereza> (raw)
In-Reply-To: <536C82F1.6020809@linutronix.de>

On 09 May 09:25 AM, Sebastian Andrzej Siewior wrote:
> On 05/09/2014 08:22 AM, George Cherian wrote:
> > Just by remodelling the dt the whole problem can be solved.
> > I am still not convinced why we should not be doing it?
> > Because neither ways its not the exact representation of the H/W.
> 
> Ha. Now I am confused. First I assumed that the musb_am335x module is
> built-in only to duct-tape the bug you are seeing. So this patch never
> made it mainline then.

Mainline panics easily upon module removal: 

$ modprobe musb_am335x
$ modprobe musb_dsps

Here you insert something to the USB

$ modprobe musb_am335x -r ... bang! the kernel panics.

It works fine if you remove the musb_dsps and musb_am335x in that order,
but the dependency is not enforced anywhere.

So I guess preventing the module removal should be fine for now.
In that case, mind testing/acking/whatever this patch:

http://www.spinics.net/lists/linux-usb/msg107244.html

Regards,
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar

  parent reply	other threads:[~2014-05-09 13:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 21:11 [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early Ezequiel Garcia
2014-04-24 21:11 ` Ezequiel Garcia
2014-04-29  6:19 ` Yegor Yefremov
2014-04-29  6:19   ` Yegor Yefremov
2014-04-29  7:58   ` George Cherian
2014-04-29  7:58     ` George Cherian
2014-04-29  8:06     ` Sebastian Andrzej Siewior
2014-04-29  8:06       ` Sebastian Andrzej Siewior
2014-04-29  8:27       ` George Cherian
2014-04-29  8:27         ` George Cherian
2014-04-29  9:09         ` Sebastian Andrzej Siewior
2014-04-29  9:09           ` Sebastian Andrzej Siewior
2014-04-29 13:50           ` Ezequiel García
2014-04-29 13:50             ` Ezequiel García
2014-05-08 17:00     ` Ezequiel García
2014-05-08 17:00       ` Ezequiel García
2014-05-09  6:22       ` George Cherian
2014-05-09  6:22         ` George Cherian
2014-05-09  7:25         ` Sebastian Andrzej Siewior
2014-05-09  7:25           ` Sebastian Andrzej Siewior
2014-05-09 10:07           ` George Cherian
2014-05-09 10:07             ` George Cherian
2014-05-09 13:26           ` Ezequiel García [this message]
2014-05-09 13:26             ` Ezequiel García
2014-05-12  4:59 ` George Cherian
2014-05-12  4:59   ` George Cherian
2014-05-12 14:02   ` Ezequiel Garcia
2014-05-12 14:02     ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140509132651.GD764@arch.cereza \
    --to=ezequiel@vanguardiasur.com.ar \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=bigeasy@linutronix.de \
    --cc=george.cherian@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.