From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Kinglong Mee <kinglongmee@gmail.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] NFSD: Don't clear SUID/SGID after root writing data
Date: Fri, 9 May 2014 22:10:17 -0700 [thread overview]
Message-ID: <20140510051017.GA23444@infradead.org> (raw)
In-Reply-To: <20140509214056.GC497@fieldses.org>
On Fri, May 09, 2014 at 05:40:57PM -0400, J. Bruce Fields wrote:
> On Fri, May 09, 2014 at 03:55:03PM +0800, Kinglong Mee wrote:
> > On 5/9/2014 00:12, J. Bruce Fields wrote:
> > > I'd like to apply this if only to remove the redundant code.
> > >
> > > I'd like to understand, though, whether this is something that caused an
> > > actual practical problem for someone, or if you just happened to notice
> > > the inconsistency between nfs and ext4 behavior?
> >
> > I test it with ext2,ext3,btrfs,xfs.
> > Test result is same as ext4.
> > So, we needs remove the redundant killing of suid/sgid.
>
> Understood that this would make the behavior consistent with
> filesystems. But, you don't know of any cases of the current behavior
> is actually causing a problem for anyone?
I thin this also is the root cause for xfstests generic/193 failing on
NFS, but I haven't verified it yet.
next prev parent reply other threads:[~2014-05-10 5:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 15:11 [PATCH] NFSD: Checking whether kill_suid by should_remove_suid() Kinglong Mee
2014-04-18 13:02 ` J. Bruce Fields
2014-04-18 13:51 ` Kinglong Mee
2014-04-18 16:17 ` [PATCH v2] NFSD: Don't clear SUID/SGID after root writing data Kinglong Mee
2014-05-08 16:12 ` J. Bruce Fields
2014-05-09 7:55 ` Kinglong Mee
2014-05-09 21:40 ` J. Bruce Fields
2014-05-10 5:10 ` Christoph Hellwig [this message]
2014-05-16 7:31 ` Kinglong Mee
2014-05-16 15:12 ` Christoph Hellwig
2014-04-18 16:25 ` [PATCH] NFSD: Checking whether kill_suid by should_remove_suid() Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140510051017.GA23444@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.