All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] tcl: needs threads
Date: Sun, 11 May 2014 08:13:53 +0300	[thread overview]
Message-ID: <20140511051353.GC4096@tarshish> (raw)
In-Reply-To: <20140508211528.D9EA29CB25@busybox.osuosl.org>

Hi Peter,

On Thu, May 08, 2014 at 11:14:17PM +0200, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=a1134320e6ff0e34df79459a490b43d6582497bc
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> Fixes http://autobuild.buildroot.net/results/486/48696710a270ac69d6d62654779f164075cb3451/
> 
> Tcl itself has a --disable-threads configure flag, but it unconditially
> configures its packages with --enable-threads, causing build failure.

Actually it's only the itcl extension that enables threading unconditionally 
in the version we use. This has changed in the development tree. See 
http://core.tcl.tk/itcl/ci/d0b8b2fa30f9f74b0779ea871eb5883b43d6096b?sbs=0 . So 
on the next version bump a no threads build should work again.

baruch

> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/tcl/Config.in |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/tcl/Config.in b/package/tcl/Config.in
> index db41d65..c3d0d87 100644
> --- a/package/tcl/Config.in
> +++ b/package/tcl/Config.in
> @@ -3,14 +3,15 @@ config BR2_PACKAGE_TCL
>  	# fork()
>  	depends on BR2_USE_MMU
>  	depends on BR2_INET_IPV6
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	help
>  	  TCL (Tool Command Language) is a simple textual language.
>  
>  	  http://www.tcl.tk
>  
> -comment "tcl needs a toolchain w/ ipv6"
> +comment "tcl needs a toolchain w/ ipv6, threads"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_INET_IPV6
> +	depends on !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
>  
>  if BR2_PACKAGE_TCL

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2014-05-11  5:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 21:14 [Buildroot] [git commit] tcl: needs threads Peter Korsgaard
2014-05-11  5:13 ` Baruch Siach [this message]
2014-05-11  7:33   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140511051353.GC4096@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.