Re: [LTP] [PATCH] lib/tst_sig.c: output signal name when got unexpected signal

[chrubis@suse.cz]

Hi!
> >>  lib/errnos.h  |  2 +-
> >>  lib/signame.h | 92 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  lib/tst_res.c |  3 ++
> >>  lib/tst_sig.c |  4 ++-
> >>  4 files changed, 99 insertions(+), 2 deletions(-)
> >>  create mode 100644 lib/signame.h
> >>
> >> diff --git a/lib/errnos.h b/lib/errnos.h
> >> index 8e80e07..bb42233 100644
> >> --- a/lib/errnos.h
> >> +++ b/lib/errnos.h
> >> @@ -27,7 +27,7 @@
> >>  
> >>  static const char *strerrnodef(int err)
> >>  {
> >> -	struct pair errno_pairs[] = {
> >> +	static struct pair errno_pairs[] = {
> >>  		{.name = "SUCCESS", .val = 0},
> >>  		/* asm-generic/errno-base.h */
> >>  		PAIR(EPERM)
> > Why have you removed the static? Do we need to have the errno_pairs
> > variable visible outside the tst_res.c?
> Here I added the static modifier, not removed,  to let errno_pairs array not be
> allocated in the stack in every strerrnodef call.

My bad, I've mistaken addition/removal. We should also declare it as const too.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list