From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: George Cherian <george.cherian@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Felipe Balbi <balbi@ti.com>,
Benoit Cousson <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early
Date: Mon, 12 May 2014 11:02:26 -0300 [thread overview]
Message-ID: <20140512140226.GA20360@arch.cereza> (raw)
In-Reply-To: <53705548.7020400@ti.com>
On 12 May 10:29 AM, George Cherian wrote:
> On 4/25/2014 2:41 AM, Ezequiel Garcia wrote:
> >The DMA controller is needed for the USB controller to be correctly
> >registered. Therefore, if the DMA node is located at the end an unecessary
> >probe deferral is produced systematically.
> >
> >This is easily fixed by moving the node at the beggining of the child list,
> >so it's probed first.
> >
> >Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Acked-by: George Cherian <george.cherian@ti.com>
Actually, I'm having second thoughts about this patch. I think it's really
fragile to depend on the devicetree ordering. Instead, I've prepared a patch
that forces the driver to probe the nodes in strict order, based in the
compatible string.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel@vanguardiasur.com.ar (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early
Date: Mon, 12 May 2014 11:02:26 -0300 [thread overview]
Message-ID: <20140512140226.GA20360@arch.cereza> (raw)
In-Reply-To: <53705548.7020400@ti.com>
On 12 May 10:29 AM, George Cherian wrote:
> On 4/25/2014 2:41 AM, Ezequiel Garcia wrote:
> >The DMA controller is needed for the USB controller to be correctly
> >registered. Therefore, if the DMA node is located at the end an unecessary
> >probe deferral is produced systematically.
> >
> >This is easily fixed by moving the node at the beggining of the child list,
> >so it's probed first.
> >
> >Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Acked-by: George Cherian <george.cherian@ti.com>
Actually, I'm having second thoughts about this patch. I think it's really
fragile to depend on the devicetree ordering. Instead, I've prepared a patch
that forces the driver to probe the nodes in strict order, based in the
compatible string.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2014-05-12 14:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 21:11 [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early Ezequiel Garcia
2014-04-24 21:11 ` Ezequiel Garcia
2014-04-29 6:19 ` Yegor Yefremov
2014-04-29 6:19 ` Yegor Yefremov
2014-04-29 7:58 ` George Cherian
2014-04-29 7:58 ` George Cherian
2014-04-29 8:06 ` Sebastian Andrzej Siewior
2014-04-29 8:06 ` Sebastian Andrzej Siewior
2014-04-29 8:27 ` George Cherian
2014-04-29 8:27 ` George Cherian
2014-04-29 9:09 ` Sebastian Andrzej Siewior
2014-04-29 9:09 ` Sebastian Andrzej Siewior
2014-04-29 13:50 ` Ezequiel García
2014-04-29 13:50 ` Ezequiel García
2014-05-08 17:00 ` Ezequiel García
2014-05-08 17:00 ` Ezequiel García
2014-05-09 6:22 ` George Cherian
2014-05-09 6:22 ` George Cherian
2014-05-09 7:25 ` Sebastian Andrzej Siewior
2014-05-09 7:25 ` Sebastian Andrzej Siewior
2014-05-09 10:07 ` George Cherian
2014-05-09 10:07 ` George Cherian
2014-05-09 13:26 ` Ezequiel García
2014-05-09 13:26 ` Ezequiel García
2014-05-12 4:59 ` George Cherian
2014-05-12 4:59 ` George Cherian
2014-05-12 14:02 ` Ezequiel Garcia [this message]
2014-05-12 14:02 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512140226.GA20360@arch.cereza \
--to=ezequiel@vanguardiasur.com.ar \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bigeasy@linutronix.de \
--cc=george.cherian@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.