From: Shawn Guo <shawn.guo@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com, lars@metafoo.de,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: wm8962: Update register CLASS_D_CONTROL_1 to be non-volatile
Date: Tue, 13 May 2014 22:29:31 +0800 [thread overview]
Message-ID: <20140513142926.GA12916@dragon> (raw)
In-Reply-To: <1399985115-29117-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Tue, May 13, 2014 at 01:45:15PM +0100, Charles Keepax wrote:
> The register CLASS_D_CONTROL_1 is marked as volatile because it contains
> a bit, DAC_MUTE, which is also mirrored in the ADC_DAC_CONTROL_1
> register. This causes problems for the "Speaker Switch" control, which
> will report an error if the CODEC is suspended because it relies on a
> volatile register.
>
> To resolve this issue mark CLASS_D_CONTROL_1 as non-volatile and
> manually keep the register cache in sync by updating both bits when
> changing the mute status.
>
> Reported-by: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> Hi Shawn,
>
> I am afraid I don't have access to hardware for 8962 at the
> moment, so have only build tested this, but I believe it
> should fix your issue.
Yes, it fixes my issue. Thanks, Charles.
Tested-by: Shawn Guo <shawn.guo@linaro.org>
next prev parent reply other threads:[~2014-05-13 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 12:45 [PATCH] ASoC: wm8962: Update register CLASS_D_CONTROL_1 to be non-volatile Charles Keepax
2014-05-13 14:29 ` Shawn Guo [this message]
2014-05-13 18:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513142926.GA12916@dragon \
--to=shawn.guo@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.