From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v4 5/6] ARM: dts: am43x-epos-evm: fix reg and range property of GPMC NAND node Date: Tue, 13 May 2014 10:32:18 -0700 Message-ID: <20140513173218.GJ16837@atomide.com> References: <1399668412-10818-1-git-send-email-pekon@ti.com> <1399668412-10818-3-git-send-email-pekon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:50456 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbaEMRcW (ORCPT ); Tue, 13 May 2014 13:32:22 -0400 Content-Disposition: inline In-Reply-To: <1399668412-10818-3-git-send-email-pekon@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Pekon Gupta Cc: bcousson@baylibre.com, linux-omap * Pekon Gupta [140509 13:48]: > 1) NAND device memory is not directly accessible to CPU, its indirectly accessed > via registers. So the 'reg' property for GPMC NAND nodes should be limited to > address range of internal GPMC registers only. > 2) Also, minimum granularity of address space under a GPMC chip-select is 16MB > so 'range' property for GPMC NAND node should specify 16MB as its memory-size > 3) On AM437x, address map of external memory accessible via GPMC starts from 0x0 > > Signed-off-by: Pekon Gupta > --- > arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts > index fd29930..63a6a59 100644 > --- a/arch/arm/boot/dts/am43x-epos-evm.dts > +++ b/arch/arm/boot/dts/am43x-epos-evm.dts > @@ -287,9 +287,9 @@ > status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&nand_flash_x8>; > - ranges = <0 0 0x08000000 0x10000000>; /* CS0: NAND */ > + ranges = <0 0 0 0x1000000>; /* CS0: NAND */ > nand@0,0 { > - reg = <0 0 0>; /* CS0, offset 0 */ > + reg = <0 0 0x380>; /* CS0, offset=0, re-map size=0x380 */ > ti,nand-ecc-opt = "bch8"; > ti,elm-id = <&elm>; > nand-bus-width = <8>; > Here too let's use the standard comments while fixing up the GPMC ranges. Tony