All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] FS/CODA: replace printk by pr_foo()
Date: Tue, 13 May 2014 14:16:30 -0400	[thread overview]
Message-ID: <20140513181629.GA24191@cs.cmu.edu> (raw)
In-Reply-To: <20140513184909.e5ccec32a70c2722c43c1d1e@skynet.be>

On Tue, May 13, 2014 at 06:49:09PM +0200, Fabian Frederick wrote:
> No level printk converted to pr_warn or pr_info
> 
> Cc: Jan Harkes <jaharkes@cs.cmu.edu>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---

Ack, those are nice cleanups for those ugly printk's. Looks like it will
shave off a few KB of memory too by making the strings shorter.

Jan

>  fs/coda/cnode.c      |  4 ++--
>  fs/coda/coda_linux.h |  2 +-
>  fs/coda/dir.c        | 12 ++++++------
>  fs/coda/inode.c      | 29 +++++++++++++++--------------
>  fs/coda/psdev.c      | 34 +++++++++++++++++-----------------
>  fs/coda/upcall.c     | 14 +++++++-------
>  6 files changed, 48 insertions(+), 47 deletions(-)

  reply	other threads:[~2014-05-13 19:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 16:49 [PATCH 1/3] FS/CODA: replace printk by pr_foo() Fabian Frederick
2014-05-13 18:16 ` Jan Harkes [this message]
2014-05-13 19:13   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140513181629.GA24191@cs.cmu.edu \
    --to=jaharkes@cs.cmu.edu \
    --cc=akpm@linux-foundation.org \
    --cc=fabf@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.